From mboxrd@z Thu Jan 1 00:00:00 1970 From: minyard@acm.org Subject: [PATCH v2 3/3] ipmi: Handle I2C parms in the SSIF driver. Date: Tue, 10 May 2016 11:11:39 -0500 Message-ID: <1462896699-1627-4-git-send-email-minyard@acm.org> References: <1462896699-1627-1-git-send-email-minyard@acm.org> Return-path: Received: from mail-pa0-f67.google.com ([209.85.220.67]:33095 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752011AbcEJQLr (ORCPT ); Tue, 10 May 2016 12:11:47 -0400 Received: by mail-pa0-f67.google.com with SMTP id gh9so1205595pac.0 for ; Tue, 10 May 2016 09:11:46 -0700 (PDT) In-Reply-To: <1462896699-1627-1-git-send-email-minyard@acm.org> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Wolfram Sang , linux-i2c@vger.kernel.org, Jean Delvare Cc: minyard@acm.org, Corey Minyard From: Corey Minyard Signed-off-by: Corey Minyard --- drivers/char/ipmi/ipmi_ssif.c | 62 ++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 61 insertions(+), 1 deletion(-) diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c index 097c868..bbd9744 100644 --- a/drivers/char/ipmi/ipmi_ssif.c +++ b/drivers/char/ipmi/ipmi_ssif.c @@ -200,7 +200,7 @@ struct ssif_info { struct ipmi_smi_msg *waiting_msg; struct ipmi_smi_msg *curr_msg; enum ssif_intf_state ssif_state; - unsigned long ssif_debug; + unsigned int ssif_debug; struct ipmi_smi_handlers handlers; @@ -1386,6 +1386,60 @@ restart: return found; } +static int ssif_parse_parms(struct ssif_info *ssif_info, + const char *parms, u8 *slave_addr) +{ + int rv; + char end; + + if (!parms) + return 0; + + while (*parms) { + const char *next = parms; + const char *val; + int parmlen; + + while (*next && !isspace(*next) && *next != '=') + next++; + + if (*next != '=') { + pr_err("IPMI SSIF invalid parm starting at %s\n", + parms); + return -EINVAL; + } + + parmlen = next - parms; + next++; + val = next; + while (*next && !isspace(*next)) + next++; + + if (strncmp(parms, "ipmb", parmlen) == 0) { + rv = sscanf(val, "%hhx%c", slave_addr, &end); + if ((rv < 1) || ((rv > 1) && !isspace(end))) { + pr_err("Invalid ipmb address: %s\n", val); + return -EINVAL; + } + } else if (strncmp(parms, "debug", parmlen) == 0) { + rv = sscanf(val, "%i%c", &ssif_info->ssif_debug, &end); + if ((rv < 1) || ((rv > 1) && !isspace(end))) { + pr_err("Invalid debug value: %s\n", val); + return -EINVAL; + } + } else { + pr_err("Invalid IPMI SSIF parameter: %s\n", parms); + return -EINVAL; + } + + while (*next && isspace(*next)) + next++; + parms = next; + } + + return 0; +} + static bool check_acpi(struct ssif_info *ssif_info, struct device *dev) { #ifdef CONFIG_ACPI @@ -1435,6 +1489,12 @@ static int ssif_probe(struct i2c_client *client, const struct i2c_device_id *id) if (!addr_info) { /* Must have come in through sysfs. */ ssif_info->addr_source = SI_HOTMOD; + rv = ssif_parse_parms(ssif_info, client->parms, + &slave_addr); + if (rv) { + pr_err(PFX "Unable to parse parms from i2c\n"); + goto out; + } } else { ssif_info->addr_source = addr_info->addr_src; ssif_info->ssif_debug = addr_info->debug; -- 2.7.4