From: Rob Herring <robh@kernel.org>
To: Phil Reid <preid@electromag.com.au>
Cc: wsa@the-dreams.de, mark.rutland@arm.com, sre@kernel.org,
peda@axentia.se, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
benjamin.tissoires@redhat.com,
Karl-Heinz Schneider <karl-heinz@schneider-inet.de>
Subject: Re: [PATCH v6 6/8] Documentation: Add sbs-manager device tree node documentation
Date: Mon, 8 May 2017 10:26:43 -0500 [thread overview]
Message-ID: <20170508152643.cv42nvkcsf3skmy2@rob-hp-laptop> (raw)
In-Reply-To: <1493716346-58517-7-git-send-email-preid@electromag.com.au>
On Tue, May 02, 2017 at 05:12:24PM +0800, Phil Reid wrote:
> From: Karl-Heinz Schneider <karl-heinz@schneider-inet.de>
>
> This patch adds device tree documentation for the sbs-manager
>
> Reviewed-by: Phil Reid <preid@electromag.com.au>
> Signed-off-by: Karl-Heinz Schneider <karl-heinz@schneider-inet.de>
> Signed-off-by: Phil Reid <preid@electromag.com.au>
> ---
> .../bindings/power/supply/sbs,sbs-manager.txt | 66 ++++++++++++++++++++++
> 1 file changed, 66 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.txt
>
> diff --git a/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.txt b/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.txt
> new file mode 100644
> index 0000000..389016c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/sbs,sbs-manager.txt
> @@ -0,0 +1,66 @@
> +Binding for sbs-manager
> +
> +Required properties:
> +- compatible: "<vendor>,<part-number>", "sbs,sbs-charger" as fallback. The part
> + number compatible string might be used in order to take care of vendor
> + specific registers.
> +- reg: integer, i2c address of the device. Should be <0xa>.
> +Optional properties:
> +- gpio-controller: Marks the port as GPIO controller.
> + See "gpio-specifier" in .../devicetree/bindings/gpio/gpio.txt.
> +- #gpio-cells: Should be <2>. The first cell is the pin number, the second cell
> + is used to specify optional parameters:
> + See "gpio-specifier" in .../devicetree/bindings/gpio/gpio.txt.
> +
> +From OS view the device is basically an i2c-mux used to communicate with up to
> +four smart battery devices at address 0xb. The driver actually implements this
> +behaviour. So standard i2c-mux nodes can be used to register up to four slave
> +batteries. Channels will be numerated starting from 1 to 4.
> +
> +Example:
> +
> +batman@0a {
Drop the leading 0.
> + compatible = "lltc,ltc1760", "sbs,sbs-manager";
> + reg = <0x0a>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + i2c@1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <1>;
> +
> + battery@0b {
Drop the leading 0.
> + compatible = "ti,bq2060", "sbs,sbs-battery";
> + reg = <0x0b>;
> + sbs,battery-detect-gpios = <&batman 1 1>;
> + };
> + };
> +
> + i2c@2 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <2>;
> +
> + battery@0b {
And here...
With that,
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2017-05-08 15:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 9:12 [PATCH v6 0/8] Add sbs-manager with smbalert support Phil Reid
2017-05-02 9:12 ` [PATCH v6 1/8] i2c: i2c-smbus: Support threaded irqs Phil Reid
2017-05-02 9:12 ` [PATCH v6 2/8] i2c: i2c-smbus: Add null ptr guard in smb_alert_probe Phil Reid
[not found] ` <1493716346-58517-1-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2017-05-02 9:12 ` [PATCH v6 3/8] i2c: i2c-smbus: add of_i2c_setup_smbus_alert Phil Reid
2017-05-02 10:20 ` Benjamin Tissoires
2017-05-03 8:31 ` Phil Reid
2017-05-08 15:24 ` Rob Herring
2017-05-02 9:12 ` [PATCH v6 8/8] power: supply: sbs-manager: Add alert callback and battery change notification Phil Reid
2017-05-04 15:21 ` Sebastian Reichel
2017-05-02 9:12 ` [PATCH v6 4/8] i2c: core: call of_i2c_setup_smbus_alert in i2c_register_adapter Phil Reid
2017-05-02 9:12 ` [PATCH v6 5/8] i2c: mux: pca954x: Call request irq after adding mux segments Phil Reid
2017-05-02 9:57 ` Peter Rosin
2017-05-03 8:36 ` Phil Reid
2017-05-02 9:12 ` [PATCH v6 6/8] Documentation: Add sbs-manager device tree node documentation Phil Reid
2017-05-08 15:26 ` Rob Herring [this message]
2017-05-02 9:12 ` [PATCH v6 7/8] power: Adds support for Smart Battery System Manager Phil Reid
2017-05-04 15:18 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170508152643.cv42nvkcsf3skmy2@rob-hp-laptop \
--to=robh@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=karl-heinz@schneider-inet.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peda@axentia.se \
--cc=preid@electromag.com.au \
--cc=sre@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).