From: Wolfram Sang <wsa@the-dreams.de>
To: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: "oss@buserror.net" <oss@buserror.net>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCHv2] i2c-mpc: Correct I2C reset procedure
Date: Mon, 29 May 2017 23:04:19 +0200 [thread overview]
Message-ID: <20170529210419.GA2527@katana> (raw)
In-Reply-To: <1495547252.17446.60.camel@infinera.com>
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
On Tue, May 23, 2017 at 01:47:34PM +0000, Joakim Tjernlund wrote:
> On Tue, 2017-05-16 at 17:13 +0200, Joakim Tjernlund wrote:
> > On Thu, 2017-05-11 at 14:20 +0200, Joakim Tjernlund wrote:
> > > Current I2C reset procedure is broken in two ways:
> > > 1) It only generate 1 START instead of 9 STARTs and STOP.
> > > 2) It leaves the bus Busy so every I2C xfer after the first
> > > fixup calls the reset routine again, for every xfer there after.
> > >
> > > This fixes both errors.
> >
> > Ping?
>
> Ping again, pretty please?
I am interested in this patch. Especially why you think the generic
recovery structure is not suitable and if we maybe need to update that,
too. But I need time to think into it and that may still need 1-2 weeks.
I am aiming for 4.12 nonetheless.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-05-29 21:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 12:20 [PATCHv2] i2c-mpc: Correct I2C reset procedure Joakim Tjernlund
2017-05-16 15:13 ` Joakim Tjernlund
2017-05-23 13:47 ` Joakim Tjernlund
2017-05-24 0:58 ` Scott Wood
2017-05-29 21:04 ` Wolfram Sang [this message]
2017-05-29 22:03 ` Joakim Tjernlund
2017-06-21 21:36 ` Wolfram Sang
2017-06-21 21:59 ` Wolfram Sang
2017-06-22 8:40 ` Joakim Tjernlund
2017-06-22 10:00 ` Wolfram Sang
2017-06-22 11:39 ` Joakim Tjernlund
2017-06-18 16:27 ` Joakim Tjernlund
2021-11-29 11:51 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170529210419.GA2527@katana \
--to=wsa@the-dreams.de \
--cc=Joakim.Tjernlund@infinera.com \
--cc=linux-i2c@vger.kernel.org \
--cc=oss@buserror.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).