From: Jean Delvare <jdelvare@suse.de>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: linux-i2c@vger.kernel.org, linux-doc@vger.kernel.org,
Wolfram Sang <wsa@the-dreams.de>, Peter Rosin <peda@axentia.se>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/28] docs: i2c: sort index logically
Date: Fri, 24 Jan 2020 13:35:48 +0100 [thread overview]
Message-ID: <20200124133548.7f01344a@endymion> (raw)
In-Reply-To: <20200123135103.20540-2-luca@lucaceresoli.net>
On Thu, 23 Jan 2020 14:50:36 +0100, Luca Ceresoli wrote:
> The index page currently lists sections in alphabetical file order without
> caring about their content. Sort sections based on their content logically,
> according to the following structure:
>
> * Intro to I2C/SMBus and their usage in Linux: summary, i2c-protocol,
> smbus-protocol, instantiating-devices, busses/index, i2c-topology,
> muxes/i2c-mux-gpio
> * Implementing drivers: writing-clients, dev-interface,
> dma-considerations, fault-codes, functionality
> * Debugging: gpio-fault-injection, i2c-stub
> * Slave I2C: slave-interface, slave-eeprom-backend
> * Advanced: ten-bit-addresses
> * Obsolete info: upgrading-clients, old-module-parameters
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> Reviewed-by: Jean Delvare <jdelvare@suse.de>
>
> ---
>
> Changes in v2:
> - split sections in groups (suggested by Jean Delvare)
> - remove consecutive blank lines (reported by Jean Delvare)
> ---
> Documentation/i2c/index.rst | 59 ++++++++++++++++++++++++++++++-------
> 1 file changed, 48 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/i2c/index.rst b/Documentation/i2c/index.rst
> index a0fbaf6d0675..f0f3b9c97abb 100644
> --- a/Documentation/i2c/index.rst
> +++ b/Documentation/i2c/index.rst
> @@ -4,30 +4,67 @@
> I2C/SMBus Subsystem
> ===================
>
> +Introduction
> +============
> +
> +.. toctree::
> + :maxdepth: 1
> +
> + summary
> + i2c-protocol
> + smbus-protocol
> + instantiating-devices
> + busses/index
> + i2c-topology
> + muxes/i2c-mux-gpio
> +
> +
You still have a double blank line here, not sure if this is intended?
Looks good otherwise.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
> +Writing device drivers
> +======================
> +
> .. toctree::
> :maxdepth: 1
>
> + writing-clients
> dev-interface
> dma-considerations
> fault-codes
> functionality
> +
> +Debugging
> +=========
> +
> +.. toctree::
> + :maxdepth: 1
> +
> gpio-fault-injection
> - i2c-protocol
> i2c-stub
> - i2c-topology
> - instantiating-devices
> - old-module-parameters
> - slave-eeprom-backend
> +
> +Slave I2C
> +=========
> +
> +.. toctree::
> + :maxdepth: 1
> +
> slave-interface
> - smbus-protocol
> - summary
> + slave-eeprom-backend
> +
> +Advanced topics
> +===============
> +
> +.. toctree::
> + :maxdepth: 1
> +
> ten-bit-addresses
> - upgrading-clients
> - writing-clients
>
> - muxes/i2c-mux-gpio
> +Legacy documentation
> +====================
>
> - busses/index
> +.. toctree::
> + :maxdepth: 1
> +
> + upgrading-clients
> + old-module-parameters
>
> .. only:: subproject and html
>
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2020-01-24 12:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 13:50 [PATCH v2 00/28] docs: i2c: rework I2C documentation, part I Luca Ceresoli
2020-01-23 13:50 ` [PATCH v2 01/28] docs: i2c: sort index logically Luca Ceresoli
2020-01-24 12:35 ` Jean Delvare [this message]
2020-01-29 12:22 ` Luca Ceresoli
2020-01-23 13:50 ` [PATCH v2 02/28] docs: i2c: summary: extend introduction Luca Ceresoli
2020-01-24 13:24 ` Jean Delvare
2020-01-23 13:50 ` [PATCH v2 03/28] docs: i2c: summary: rewrite the "terminology" section Luca Ceresoli
2020-01-24 13:28 ` Jean Delvare
2020-01-23 13:50 ` [PATCH v2 04/28] docs: i2c: call it "I2C" consistently Luca Ceresoli
2020-01-23 13:50 ` [PATCH v2 05/28] docs: i2c: fix typo Luca Ceresoli
2020-01-23 13:50 ` [PATCH v2 06/28] docs: i2c: replace "I2C-transfer" -> "I2C transfer" consistently Luca Ceresoli
2020-01-23 13:50 ` [PATCH v2 07/28] docs: i2c: i2c-protocol: fix kernel-doc function syntax Luca Ceresoli
2020-01-23 13:50 ` [PATCH v2 08/28] docs: i2c: i2c-protocol: properly name start and stop conditions Luca Ceresoli
2020-01-23 13:50 ` [PATCH v2 09/28] docs: i2c: i2c-protocol: remove unneeded colons from table Luca Ceresoli
2020-01-23 13:50 ` [PATCH v2 10/28] docs: i2c: i2c-protocol: use proper names for ACK and NACK Luca Ceresoli
2020-01-23 13:50 ` [PATCH v2 11/28] docs: i2c: smbus: fix link syntax Luca Ceresoli
2020-01-24 14:57 ` Jean Delvare
2020-01-23 13:50 ` [PATCH v2 12/28] docs: i2c: smbus-protocol: properly name start and stop conditions Luca Ceresoli
2020-01-23 13:50 ` [PATCH v2 13/28] docs: i2c: smbus-protocol: remove unneeded colons from table Luca Ceresoli
2020-01-23 14:56 ` [PATCH v2 14/28] docs: i2c: smbus-protocol: use proper names for ACK and NACK Luca Ceresoli
2020-01-23 14:56 ` [PATCH v2 15/28] docs: i2c: smbus-protocol: enable kernel-doc function syntax Luca Ceresoli
2020-01-23 14:56 ` [PATCH v2 16/28] docs: i2c: smbus-protocol: fix " Luca Ceresoli
2020-01-23 14:56 ` [PATCH v2 17/28] docs: i2c: smbus-protocol: fix typo Luca Ceresoli
2020-01-23 14:56 ` [PATCH v2 18/28] docs: i2c: smbus-protocol: fix punctuation Luca Ceresoli
2020-01-23 14:56 ` [PATCH v2 19/28] docs: i2c: smbus-protocol: improve I2C Block transactions description Luca Ceresoli
2020-01-23 14:56 ` [PATCH v2 20/28] docs: i2c: instantiating-devices: fix internal hyperlink Luca Ceresoli
2020-01-23 14:56 ` [PATCH v2 21/28] docs: i2c: instantiating-devices: rearrange static instatiation Luca Ceresoli
2020-01-23 14:56 ` [PATCH v2 22/28] docs: i2c: instantiating-devices: use monospace for sysfs attributes Luca Ceresoli
2020-01-23 14:56 ` [PATCH v2 23/28] docs: i2c: old-module-parameters: fix internal hyperlink Luca Ceresoli
2020-01-23 14:56 ` [PATCH v2 24/28] docs: i2c: old-module-parameters: clarify this is for obsolete kernels Luca Ceresoli
2020-01-23 14:56 ` [PATCH v2 25/28] docs: i2c: old-module-parameters: use monospace instead of "" Luca Ceresoli
2020-01-23 14:56 ` [PATCH v2 26/28] docs: i2c: rename sections so the overall picture is clearer Luca Ceresoli
2020-01-23 14:56 ` [PATCH v2 27/28] docs: i2c: i2c-protocol: use same wording as smbus-protocol Luca Ceresoli
2020-01-24 15:59 ` Jean Delvare
2020-01-23 14:56 ` [PATCH v2 28/28] docs: i2c: writing-clients: properly name the stop condition Luca Ceresoli
2020-01-24 16:01 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124133548.7f01344a@endymion \
--to=jdelvare@suse.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=peda@axentia.se \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).