From: kbuild test robot <lkp@intel.com>
To: Matthew Blecker <matthewb@chromium.org>,
Wolfram Sang <wsa-dev@sang-engineering.com>,
linux-i2c@vger.kernel.org
Cc: kbuild-all@lists.01.org, Matthew Blecker <matthewb@chromium.org>
Subject: [PATCH] i2c: fix stream_open.cocci warnings
Date: Sat, 9 May 2020 09:43:32 +0800 [thread overview]
Message-ID: <20200509014331.GA22477@2b00b1f31741> (raw)
In-Reply-To: <20200507230513.246804-2-matthewb@google.com>
From: kbuild test robot <lkp@intel.com>
drivers/i2c/i2c-pseudo.c:2206:1-17: ERROR: i2cp_fileops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
Generated by: scripts/coccinelle/api/stream_open.cocci
CC: Matthew Blecker <matthewb@chromium.org>
Signed-off-by: kbuild test robot <lkp@intel.com>
---
url: https://github.com/0day-ci/linux/commits/Matthew-Blecker/i2c-Add-i2c-pseudo-driver-for-userspace-I2C-adapters/20200509-011221
base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
Please take the patch only if it's a positive warning. Thanks!
i2c-pseudo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/i2c/i2c-pseudo.c
+++ b/drivers/i2c/i2c-pseudo.c
@@ -2203,7 +2203,7 @@ static int i2cp_cdev_open(struct inode *
this_pseudo = i2cp_device;
/* I2C pseudo adapter controllers are not seekable. */
- nonseekable_open(inodep, filep);
+ stream_open(inodep, filep);
/* Refuse fsnotify events. Modeled after /dev/ptmx implementation. */
filep->f_mode |= FMODE_NONOTIFY;
prev parent reply other threads:[~2020-05-09 1:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 23:05 [PATCH 0/1] i2c: Add i2c-pseudo driver for userspace I2C adapters Matthew Blecker
2020-05-07 23:05 ` [PATCH 1/1] " Matthew Blecker
2020-05-08 20:36 ` kbuild test robot
2020-05-09 1:43 ` kbuild test robot
2020-05-09 1:43 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200509014331.GA22477@2b00b1f31741 \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-i2c@vger.kernel.org \
--cc=matthewb@chromium.org \
--cc=wsa-dev@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).