From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH v1 3/4] i2c: designware: Split out ACPI parts into separate module
Date: Mon, 11 May 2020 17:05:16 +0300 [thread overview]
Message-ID: <20200511140516.GL185537@smile.fi.intel.com> (raw)
In-Reply-To: <407cc9b3-fd56-43bf-1361-c6b1aec0442f@linux.intel.com>
On Mon, May 11, 2020 at 04:31:18PM +0300, Jarkko Nikula wrote:
> On 5/7/20 4:51 PM, Andy Shevchenko wrote:
> > For better maintenance and possible code reuse in the future,
> > split out ACPI parts into a separate module.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/i2c/busses/Makefile | 3 +
> > drivers/i2c/busses/i2c-designware-acpi.c | 130 +++++++++++++++++
> > drivers/i2c/busses/i2c-designware-core.h | 8 ++
> > drivers/i2c/busses/i2c-designware-platdrv.c | 151 +++-----------------
> > 4 files changed, 163 insertions(+), 129 deletions(-)
> > create mode 100644 drivers/i2c/busses/i2c-designware-acpi.c
> >
> Comment to both of this and patch 2/4:
>
> I'm not so fan of introducing even more i2c-designware modules. No any other
> drivers have so many files as i2c-designware in drivers/i2c/busses/*.c.
> Feeling a bit of hall of shame because of it :-)
>
> What's the rationale here? Currently i2c-designware-platdrv.c is 512 lines
> of code so it's not too hard to maintain in my opinion.
How to use same functionality in PCI and platform driver? Are you implying that
the common.c is good enough? I would move there, of course.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-05-11 14:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 13:51 [PATCH v1 1/4] i2c: designware: Split out i2c_dw_validate_speed() helper Andy Shevchenko
2020-05-07 13:51 ` [PATCH v1 2/4] i2c: designware: Split out OF parts into separate module Andy Shevchenko
2020-05-07 13:51 ` [PATCH v1 3/4] i2c: designware: Split out ACPI " Andy Shevchenko
2020-05-11 13:31 ` Jarkko Nikula
2020-05-11 14:05 ` Andy Shevchenko [this message]
2020-05-07 13:51 ` [PATCH v1 4/4] i2c: designware: Read counters from ACPI for PCI driver Andy Shevchenko
2020-05-11 13:11 ` [PATCH v1 1/4] i2c: designware: Split out i2c_dw_validate_speed() helper Jarkko Nikula
2020-05-11 13:42 ` Andy Shevchenko
2020-05-12 15:12 ` Jarkko Nikula
2020-05-19 12:33 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511140516.GL185537@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).