From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Avi Fishman <avifishman70@gmail.com>
Cc: Tali Perry <tali.perry1@gmail.com>,
ofery@google.com, Brendan Higgins <brendanhiggins@google.com>,
Tomer Maimon <tmaimon77@gmail.com>,
kfting@nuvoton.com, Patrick Venture <venture@google.com>,
Nancy Yuen <yuenn@google.com>,
Benjamin Fair <benjaminfair@google.com>,
Rob Herring <robh+dt@kernel.org>,
wsa@the-dreams.de,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-i2c@vger.kernel.org,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v11 2/3] i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver
Date: Wed, 20 May 2020 14:49:25 +0300 [thread overview]
Message-ID: <20200520114925.GQ1634618@smile.fi.intel.com> (raw)
In-Reply-To: <CAKKbWA5L_n7iC6-d22Am62SOoDBwNWO87+sXtRbwxwuVdjmRYA@mail.gmail.com>
On Wed, May 20, 2020 at 02:37:13PM +0300, Avi Fishman wrote:
> On Wed, May 20, 2020 at 1:24 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > On Wed, May 20, 2020 at 12:51:12PM +0300, Tali Perry wrote:
> > > Add Nuvoton NPCM BMC I2C controller driver.
> >
> > ...
> >
> > > +#ifdef CONFIG_DEBUG_FS
> >
> > Why?!
>
> It is made to save code size if CONFIG_DEBUG_FS is not defined?
Nope (in cases I have commented on). Try again.
> We see a lot of kernel code that is doing it.
Cargo cult, okay. So, somebody should try to understand what they are doing.
> So could you elaborate what is the problem?
Problem 1: ugly code.
Problem 2: some of the code is not guarded (seems never been tested with disabled debugfs).
Problem 3: it's not needed.
> > > +#include <linux/debugfs.h>
> > > +#endif
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-05-20 11:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 9:51 [PATCH v11 0/3] i2c: npcm7xx: add NPCM i2c controller driver Tali Perry
2020-05-20 9:51 ` [PATCH v11 1/3] dt-bindings: i2c: npcm7xx: add NPCM I2C controller Tali Perry
2020-05-21 14:08 ` Rob Herring
2020-05-20 9:51 ` [PATCH v11 2/3] i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver Tali Perry
2020-05-20 10:24 ` Andy Shevchenko
2020-05-20 11:37 ` Avi Fishman
2020-05-20 11:49 ` Andy Shevchenko [this message]
2020-05-20 9:51 ` [PATCH v11 3/3] i2c: npcm7xx: Add support for slave mode for Nuvoton Tali Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520114925.GQ1634618@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=brendanhiggins@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kfting@nuvoton.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ofery@google.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=wsa@the-dreams.de \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).