From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Rob Herring <robh+dt@kernel.org>, <linux-mips@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 10/11] i2c: designware: Move reg-space remapping into a dedicated function
Date: Wed, 27 May 2020 17:54:35 +0300 [thread overview]
Message-ID: <20200527145435.bfout2oyonupxlac@mobilestation> (raw)
In-Reply-To: <20200527135801.GB1634618@smile.fi.intel.com>
On Wed, May 27, 2020 at 04:58:01PM +0300, Andy Shevchenko wrote:
> On Wed, May 27, 2020 at 03:01:10PM +0300, Serge Semin wrote:
> > This is a preparation patch before adding a quirk with custom registers
> > map creation required for the Baikal-T1 System I2C support.
>
> Looks good. Though one nit below.
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> > Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: linux-mips@vger.kernel.org
> > Cc: devicetree@vger.kernel.org
> >
> > ---
> >
> > Changelog v3:
> > - This is a new patch, which has been created due to declining the
> > glue-layer approach.
> >
> > Changelog v4:
> > - Use PTR_ERR_OR_ZERO() helper in the bt1_i2c_request_regs() method.
> > - Discard devm_platform_get_and_ioremap_resource() utilization.
> > ---
> > drivers/i2c/busses/i2c-designware-platdrv.c | 18 +++++++++++++-----
> > 1 file changed, 13 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> > index ad292de2d260..061c8d506c7c 100644
> > --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> > @@ -108,6 +108,15 @@ static void dw_i2c_plat_pm_cleanup(struct dw_i2c_dev *dev)
> > pm_runtime_put_noidle(dev->dev);
> > }
> >
> > +static int dw_i2c_plat_request_regs(struct dw_i2c_dev *dev)
> > +{
> > + struct platform_device *pdev = to_platform_device(dev->dev);
> > +
> > + dev->base = devm_platform_ioremap_resource(pdev, 0);
> > +
> > + return PTR_ERR_OR_ZERO(dev->base);
> > +}
> > +
> > static int dw_i2c_plat_probe(struct platform_device *pdev)
> > {
> > struct dw_i2c_platform_data *pdata = dev_get_platdata(&pdev->dev);
> > @@ -125,15 +134,14 @@ static int dw_i2c_plat_probe(struct platform_device *pdev)
> > return -ENOMEM;
> >
>
> > dev->flags |= (uintptr_t)device_get_match_data(&pdev->dev);
>
> It's related to previous patch, but I just realized that '|' is not needed
> here. Care to amend in the previous patch?
Agreed. Thanks.
-Sergey
>
> > -
> > - dev->base = devm_platform_ioremap_resource(pdev, 0);
> > - if (IS_ERR(dev->base))
> > - return PTR_ERR(dev->base);
> > -
> > dev->dev = &pdev->dev;
> > dev->irq = irq;
> > platform_set_drvdata(pdev, dev);
> >
> > + ret = dw_i2c_plat_request_regs(dev);
> > + if (ret)
> > + return ret;
> > +
> > dev->rst = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL);
> > if (IS_ERR(dev->rst))
> > return PTR_ERR(dev->rst);
> > --
> > 2.26.2
> >
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
next prev parent reply other threads:[~2020-05-27 14:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 12:01 [PATCH v4 00/11] i2c: designeware: Add Baikal-T1 System I2C support Serge Semin
2020-05-27 12:01 ` [PATCH v4 01/11] dt-bindings: i2c: Convert DW I2C binding to DT schema Serge Semin
2020-05-27 12:01 ` [PATCH v4 02/11] dt-bindings: i2c: Discard i2c-slave flag from the DW I2C example Serge Semin
2020-05-27 17:12 ` Rob Herring
2020-05-27 17:18 ` Serge Semin
2020-05-27 17:56 ` Andy Shevchenko
2020-05-28 8:39 ` Serge Semin
2020-05-28 10:00 ` Andy Shevchenko
2020-05-27 12:01 ` [PATCH v4 03/11] dt-bindings: i2c: dw: Add Baikal-T1 SoC I2C controller Serge Semin
2020-05-27 12:01 ` [PATCH v4 04/11] i2c: designware: Use `-y` to build multi-object modules Serge Semin
2020-05-27 12:01 ` [PATCH v4 05/11] i2c: designware: slave: Set DW I2C core module dependency Serge Semin
2020-05-27 12:01 ` [PATCH v4 06/11] i2c: designware: Add Baytrail sem config DW I2C platform dependency Serge Semin
2020-05-27 13:42 ` Andy Shevchenko
2020-05-27 14:24 ` Serge Semin
2020-05-27 15:46 ` Andy Shevchenko
2020-05-27 16:00 ` Serge Semin
2020-05-27 16:43 ` Andy Shevchenko
2020-05-27 12:01 ` [PATCH v4 07/11] i2c: designware: Discard Cherry Trail model flag Serge Semin
2020-05-27 13:43 ` Andy Shevchenko
2020-05-27 14:29 ` Serge Semin
2020-05-27 15:48 ` Andy Shevchenko
2020-05-27 12:01 ` [PATCH v4 08/11] i2c: designware: Convert driver to using regmap API Serge Semin
2020-05-27 13:50 ` Andy Shevchenko
2020-05-27 14:39 ` Serge Semin
2020-05-27 12:01 ` [PATCH v4 09/11] i2c: designware: Retrieve quirk flags as early as possible Serge Semin
2020-05-27 13:51 ` Andy Shevchenko
2020-05-27 12:01 ` [PATCH v4 10/11] i2c: designware: Move reg-space remapping into a dedicated function Serge Semin
2020-05-27 13:58 ` Andy Shevchenko
2020-05-27 14:54 ` Serge Semin [this message]
2020-05-27 12:01 ` [PATCH v4 11/11] i2c: designware: Add Baikal-T1 System I2C support Serge Semin
2020-05-27 14:03 ` Andy Shevchenko
2020-05-27 15:04 ` Serge Semin
2020-05-27 15:52 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527145435.bfout2oyonupxlac@mobilestation \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).