From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>,
Serge Semin <fancer.lancer@gmail.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 06/11] i2c: designware: Add Baytrail sem config DW I2C platform dependency
Date: Wed, 27 May 2020 18:55:33 +0300 [thread overview]
Message-ID: <20200527155533.GJ1634618@smile.fi.intel.com> (raw)
In-Reply-To: <20200527153046.6172-7-Sergey.Semin@baikalelectronics.ru>
On Wed, May 27, 2020 at 06:30:41PM +0300, Serge Semin wrote:
> Currently Intel Baytrail I2C semaphore is a feature of the DW APB I2C
> platform driver. It's a bit confusing to see it's config in the menu at
> some separated place with no reference to the platform code. Let's move the
> config definition to be below the I2C_DESIGNWARE_PLATFORM config and mark
> it with "depends on I2C_DESIGNWARE_PLATFORM" statement. By doing so the
> config menu will display the feature right below the DW I2C platform
> driver item and will indent it to the right so signifying its belonging.
Same comment as per previous version.
> config I2C_DESIGNWARE_BAYTRAIL
> bool "Intel Baytrail I2C semaphore support"
> depends on ACPI
> + depends on I2C_DESIGNWARE_PLATFORM
> depends on (I2C_DESIGNWARE_PLATFORM=m && IOSF_MBI) || \
> (I2C_DESIGNWARE_PLATFORM=y && IOSF_MBI=y)
i.e. this change is not needed.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-05-27 15:55 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 15:30 [PATCH v5 00/11] i2c: designeware: Add Baikal-T1 System I2C support Serge Semin
2020-05-27 15:30 ` [PATCH v5 01/11] dt-bindings: i2c: Convert DW I2C binding to DT schema Serge Semin
2020-05-27 15:30 ` [PATCH v5 02/11] dt-bindings: i2c: Discard i2c-slave flag from the DW I2C example Serge Semin
2020-05-27 15:33 ` Serge Semin
2020-05-29 18:13 ` Rob Herring
2020-05-29 18:22 ` Serge Semin
2020-05-29 18:42 ` Andy Shevchenko
2020-05-29 18:45 ` Serge Semin
2020-05-29 18:58 ` Serge Semin
2020-06-08 23:46 ` Rob Herring
2020-05-27 15:30 ` [PATCH v5 03/11] dt-bindings: i2c: dw: Add Baikal-T1 SoC I2C controller Serge Semin
2020-05-27 15:35 ` Serge Semin
2020-05-27 15:30 ` [PATCH v5 04/11] i2c: designware: Use `-y` to build multi-object modules Serge Semin
2020-05-27 15:30 ` [PATCH v5 05/11] i2c: designware: slave: Set DW I2C core module dependency Serge Semin
2020-05-27 15:30 ` [PATCH v5 06/11] i2c: designware: Add Baytrail sem config DW I2C platform dependency Serge Semin
2020-05-27 15:55 ` Andy Shevchenko [this message]
2020-05-27 16:05 ` Serge Semin
2020-05-27 16:44 ` Andy Shevchenko
2020-05-27 15:30 ` [PATCH v5 07/11] i2c: designware: Discard Cherry Trail model flag Serge Semin
2020-05-27 15:57 ` Andy Shevchenko
2020-05-27 16:07 ` Serge Semin
2020-05-27 15:30 ` [PATCH v5 08/11] i2c: designware: Convert driver to using regmap API Serge Semin
2020-05-27 16:03 ` Andy Shevchenko
2020-05-27 16:09 ` Serge Semin
2020-05-27 15:30 ` [PATCH v5 09/11] i2c: designware: Retrieve quirk flags as early as possible Serge Semin
2020-05-27 15:30 ` [PATCH v5 10/11] i2c: designware: Move reg-space remapping into a dedicated function Serge Semin
2020-05-27 15:30 ` [PATCH v5 11/11] i2c: designware: Add Baikal-T1 System I2C support Serge Semin
2020-05-27 16:05 ` Andy Shevchenko
2020-05-27 16:10 ` Serge Semin
2020-05-27 16:08 ` [PATCH v5 00/11] i2c: designeware: " Andy Shevchenko
2020-05-27 16:15 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527155533.GJ1634618@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).