linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Saheed Olayemi Bolarinwa <refactormyself@gmail.com>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [RFC PATCH 00/35] Move all PCIBIOS* definitions into arch/x86
Date: Tue, 21 Jul 2020 15:52:23 +0200	[thread overview]
Message-ID: <20200721155223.6427b611@endymion> (raw)
In-Reply-To: <20200718184558.110942-1-refactormyself@gmail.com>

Hi Saheed,

On Sat, 18 Jul 2020 20:45:58 +0200, Saheed Olayemi Bolarinwa wrote:
> This goal of these series is to move the definition of *all* PCIBIOS* from
> include/linux/pci.h to arch/x86 and limit their use within there.
> All other tree specific definition will be left for intact. Maybe they can
> be renamed.
> 
> PCIBIOS* is an x86 concept as defined by the PCI spec. The returned error
> codes of PCIBIOS* are positive values and this introduces some complexities
> which other archs need not incur.
> 
> PLAN:
> 
> 1.   [PATCH v0 1-36] Replace all PCIBIOS_SUCCESSFUL with 0
> (...)

Thanks for the explanations. Now I understand your previous patches
better, and if you fix the alignment issues I'll be happy to approve
them.

> Bolarinwa Olayemi Saheed (35):
>   Change PCIBIOS_SUCCESSFUL to 0
>   Change PCIBIOS_SUCCESSFUL to 0
>   Change PCIBIOS_SUCCESSFUL to 0
> (...)

You'd have to prefix the patch names to make them all unique, but I
think you have done that already as the patches I received looked fine
in this respect.

-- 
Jean Delvare
SUSE L3 Support

      reply	other threads:[~2020-07-21 13:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-18 18:45 [RFC PATCH 00/35] Move all PCIBIOS* definitions into arch/x86 Saheed Olayemi Bolarinwa
2020-07-21 13:52 ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200721155223.6427b611@endymion \
    --to=jdelvare@suse.de \
    --cc=linux-i2c@vger.kernel.org \
    --cc=refactormyself@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).