linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	devicetree@vger.kernel.org, Alain Volmat <alain.volmat@st.com>
Subject: Re: [PATCH] i2c: add binding to mark a bus as SMBus
Date: Fri, 24 Jul 2020 21:36:35 +0200	[thread overview]
Message-ID: <20200724193635.GC1227@ninjato> (raw)
In-Reply-To: <20200715203843.GA776042@bogus>

[-- Attachment #1: Type: text/plain, Size: 1391 bytes --]

Hi Rob,

> > SMBus is largely compatible with I2C but there are some specifics. In
> > case we need them on a bus, we can now use this new binding.
> > 
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > ---
> >  Documentation/devicetree/bindings/i2c/i2c.txt | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt
> > index 438ae123107e..d1f8cf3bd236 100644
> > --- a/Documentation/devicetree/bindings/i2c/i2c.txt
> > +++ b/Documentation/devicetree/bindings/i2c/i2c.txt
> > @@ -77,6 +77,11 @@ wants to support one of the below features, it should adapt these bindings.
> >  	this information to detect a stalled bus more reliably, for example.
> >  	Can not be combined with 'multi-master'.
> >  
> > +- smbus
> 
> This is a boolean?

Yes.

> 
> > +	states that additional SMBus restrictions and features apply to this bus.
> > +	Examples of features are SMBusHostNotify and SMBusAlert. Examples of
> 
> Do features need to be enumerated separately?

They could be, do you think this is of advantage? For now, we would then
need "host-notify" and "smbus-alert". Maybe later things like "timeout"
could show up.

> 
> > +	restrictions are more reserved addresses and timeout definitions.
> > +

All the best,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-07-24 19:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01 21:48 [PATCH] i2c: add binding to mark a bus as SMBus Wolfram Sang
2020-07-15 20:38 ` Rob Herring
2020-07-24 19:36   ` Wolfram Sang [this message]
2020-07-25 12:07     ` Wolfram Sang
2020-07-29 10:53       ` Wolfram Sang
2020-08-21 11:43       ` Wolfram Sang
2020-09-09  8:15 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200724193635.GC1227@ninjato \
    --to=wsa+renesas@sang-engineering.com \
    --cc=alain.volmat@st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).