From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-i2c@vger.kernel.org, Robert Richter <rrichter@marvell.com>
Cc: linux-renesas-soc@vger.kernel.org,
David Daney <david.daney@cavium.com>,
Jan Glauber <jan.glauber@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] i2c: octeon: check correct size of maximum RECV_LEN packet
Date: Fri, 24 Jul 2020 21:45:18 +0200 [thread overview]
Message-ID: <20200724194518.GE1227@ninjato> (raw)
In-Reply-To: <20200628115245.9638-3-wsa+renesas@sang-engineering.com>
[-- Attachment #1: Type: text/plain, Size: 1170 bytes --]
On Sun, Jun 28, 2020 at 01:52:45PM +0200, Wolfram Sang wrote:
> I2C_SMBUS_BLOCK_MAX defines already the maximum number as defined in the
> SMBus 2.0 specs. I don't see a reason to add 1 here.
>
> Fixes: 886f6f8337dd ("i2c: octeon: Support I2C_M_RECV_LEN")
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
Robert, is this correct?
>
> Only build tested, I don't have the HW. Please let me know if I
> overlooked something, but to the best of my knowledge, this +1 is wrong.
>
> drivers/i2c/busses/i2c-octeon-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-octeon-core.c b/drivers/i2c/busses/i2c-octeon-core.c
> index d9607905dc2f..845eda70b8ca 100644
> --- a/drivers/i2c/busses/i2c-octeon-core.c
> +++ b/drivers/i2c/busses/i2c-octeon-core.c
> @@ -347,7 +347,7 @@ static int octeon_i2c_read(struct octeon_i2c *i2c, int target,
> if (result)
> return result;
> if (recv_len && i == 0) {
> - if (data[i] > I2C_SMBUS_BLOCK_MAX + 1)
> + if (data[i] > I2C_SMBUS_BLOCK_MAX)
> return -EPROTO;
> length += data[i];
> }
> --
> 2.20.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-07-24 19:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-28 11:52 [RFC PATCH 0/2] i2c: check correct size of maximum RECV_LEN packet Wolfram Sang
2020-06-28 11:52 ` [RFC PATCH 1/2] i2c: mlxcpld: " Wolfram Sang
2020-06-28 13:50 ` Michael Shych
2020-06-28 11:52 ` [RFC PATCH 2/2] i2c: octeon: " Wolfram Sang
2020-07-24 19:45 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724194518.GE1227@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=david.daney@cavium.com \
--cc=jan.glauber@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=rrichter@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).