From: Sultan Alsawaf <sultan@kerneltoast.com>
To: linux-i2c@vger.kernel.org
Cc: jikos@kernel.org, aaron.ma@canonical.com, admin@kryma.net,
andriy.shevchenko@linux.intel.com, benjamin.tissoires@redhat.com,
hdegoede@redhat.com, hn.chen@weidahitech.com,
jarkko.nikula@linux.intel.com, kai.heng.feng@canonical.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
mika.westerberg@linux.intel.com, vicamo.yang@canonical.com,
wsa@kernel.org, Sultan Alsawaf <sultan@kerneltoast.com>
Subject: [PATCH v2 3/4] i2c: designware: Allow SMBus block reads up to 255 bytes in length
Date: Wed, 16 Sep 2020 22:22:55 -0700 [thread overview]
Message-ID: <20200917052256.5770-4-sultan@kerneltoast.com> (raw)
In-Reply-To: <20200917052256.5770-1-sultan@kerneltoast.com>
From: Sultan Alsawaf <sultan@kerneltoast.com>
According to the SMBus 3.0 protocol specification, block transfer limits
were increased from 32 bytes to 255 bytes. Remove the obsolete 32-byte
limitation.
Signed-off-by: Sultan Alsawaf <sultan@kerneltoast.com>
---
drivers/i2c/busses/i2c-designware-master.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
index 22f28516bca7..5bd64bd17d94 100644
--- a/drivers/i2c/busses/i2c-designware-master.c
+++ b/drivers/i2c/busses/i2c-designware-master.c
@@ -433,7 +433,7 @@ i2c_dw_read(struct dw_i2c_dev *dev)
regmap_read(dev->map, DW_IC_DATA_CMD, &tmp);
if (flags & I2C_M_RECV_LEN) {
/* Ensure length byte is a valid value */
- if (tmp <= I2C_SMBUS_BLOCK_MAX && tmp > 0)
+ if (tmp > 0)
len = i2c_dw_recv_len(dev, tmp);
else
len = i2c_dw_recv_len(dev, len);
--
2.28.0
next prev parent reply other threads:[~2020-09-17 5:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 5:22 [PATCH v2 0/4] i2c-hid: Save power by reducing i2c xfers with block reads Sultan Alsawaf
2020-09-17 5:22 ` [PATCH v2 1/4] i2c: designware: Fix transfer failures for invalid SMBus " Sultan Alsawaf
2020-09-17 5:22 ` [PATCH v2 2/4] i2c: designware: Ensure tx_buf_len is nonzero for " Sultan Alsawaf
2020-09-17 12:47 ` Andy Shevchenko
2020-09-17 13:44 ` Jarkko Nikula
2020-09-17 14:45 ` Andy Shevchenko
2020-09-17 5:22 ` Sultan Alsawaf [this message]
2020-09-17 20:57 ` [PATCH v2 3/4] i2c: designware: Allow SMBus block reads up to 255 bytes in length Wolfram Sang
2020-09-17 23:12 ` Sultan Alsawaf
2020-09-17 5:22 ` [PATCH v2 4/4] HID: i2c-hid: Use block reads when possible to save power Sultan Alsawaf
2020-09-17 14:02 ` [PATCH v2 0/4] i2c-hid: Save power by reducing i2c xfers with block reads Andy Shevchenko
2020-09-23 13:59 ` Jarkko Nikula
2020-09-22 9:19 ` Jiri Kosina
2020-09-22 11:36 ` Wolfram Sang
2020-09-22 19:59 ` Jiri Kosina
2020-09-23 6:02 ` Sultan Alsawaf
2020-10-16 11:16 ` Hans de Goede
2020-10-16 15:24 ` Sultan Alsawaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917052256.5770-4-sultan@kerneltoast.com \
--to=sultan@kerneltoast.com \
--cc=aaron.ma@canonical.com \
--cc=admin@kryma.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=hn.chen@weidahitech.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jikos@kernel.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=vicamo.yang@canonical.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).