From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80E84C4363D for ; Fri, 25 Sep 2020 05:39:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48AD421D7A for ; Fri, 25 Sep 2020 05:39:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727016AbgIYFjJ convert rfc822-to-8bit (ORCPT ); Fri, 25 Sep 2020 01:39:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726925AbgIYFjJ (ORCPT ); Fri, 25 Sep 2020 01:39:09 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 336FAC0613CE for ; Thu, 24 Sep 2020 22:39:09 -0700 (PDT) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLgRg-0006Ae-CK; Fri, 25 Sep 2020 07:39:00 +0200 Received: from ore by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1kLgRf-0002ub-3B; Fri, 25 Sep 2020 07:38:59 +0200 Date: Fri, 25 Sep 2020 07:38:59 +0200 From: Oleksij Rempel To: Krzysztof Kozlowski Cc: Oleksij Rempel , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Wolfram Sang , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] i2c: imx: Fix external abort on interrupt in exit paths Message-ID: <20200925053859.dfk3cnjsv6xy7lqy@pengutronix.de> References: <20200920211238.13920-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20200920211238.13920-1-krzk@kernel.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 07:11:08 up 314 days, 20:29, 325 users, load average: 0.30, 0.11, 0.03 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-i2c@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Sun, Sep 20, 2020 at 11:12:38PM +0200, Krzysztof Kozlowski wrote: > If interrupt comes late, during probe error path or device remove (could > be triggered with CONFIG_DEBUG_SHIRQ), the interrupt handler > i2c_imx_isr() will access registers with the clock being disabled. This > leads to external abort on non-linefetch on Toradex Colibri VF50 module > (with Vybrid VF5xx): > > Unhandled fault: external abort on non-linefetch (0x1008) at 0x8882d003 > Internal error: : 1008 [#1] ARM > Modules linked in: > CPU: 0 PID: 1 Comm: swapper Not tainted 5.7.0 #607 > Hardware name: Freescale Vybrid VF5xx/VF6xx (Device Tree) > (i2c_imx_isr) from [<8017009c>] (free_irq+0x25c/0x3b0) > (free_irq) from [<805844ec>] (release_nodes+0x178/0x284) > (release_nodes) from [<80580030>] (really_probe+0x10c/0x348) > (really_probe) from [<80580380>] (driver_probe_device+0x60/0x170) > (driver_probe_device) from [<80580630>] (device_driver_attach+0x58/0x60) > (device_driver_attach) from [<805806bc>] (__driver_attach+0x84/0xc0) > (__driver_attach) from [<8057e228>] (bus_for_each_dev+0x68/0xb4) > (bus_for_each_dev) from [<8057f3ec>] (bus_add_driver+0x144/0x1ec) > (bus_add_driver) from [<80581320>] (driver_register+0x78/0x110) > (driver_register) from [<8010213c>] (do_one_initcall+0xa8/0x2f4) > (do_one_initcall) from [<80c0100c>] (kernel_init_freeable+0x178/0x1dc) > (kernel_init_freeable) from [<80807048>] (kernel_init+0x8/0x110) > (kernel_init) from [<80100114>] (ret_from_fork+0x14/0x20) > > Additionally, the i2c_imx_isr() could wake up the wait queue > (imx_i2c_struct->queue) before its initialization happens. > > The resource-managed framework should not be used for interrupt handling, > because the resource will be released too late - after disabling clocks. > The interrupt handler is not prepared for such case. > > Fixes: 1c4b6c3bcf30 ("i2c: imx: implement bus recovery") > Cc: > Signed-off-by: Krzysztof Kozlowski Acked-by: Oleksij Rempel Thank you! > --- > > Changes since v2: > 1. Rebase > > Changes since v1: > 1. Remove the devm- and use regular methods. > --- > drivers/i2c/busses/i2c-imx.c | 24 +++++++++++++----------- > 1 file changed, 13 insertions(+), 11 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c > index 63f4367c312b..c98529c76348 100644 > --- a/drivers/i2c/busses/i2c-imx.c > +++ b/drivers/i2c/busses/i2c-imx.c > @@ -1169,14 +1169,6 @@ static int i2c_imx_probe(struct platform_device *pdev) > return ret; > } > > - /* Request IRQ */ > - ret = devm_request_irq(&pdev->dev, irq, i2c_imx_isr, IRQF_SHARED, > - pdev->name, i2c_imx); > - if (ret) { > - dev_err(&pdev->dev, "can't claim irq %d\n", irq); > - goto clk_disable; > - } > - > /* Init queue */ > init_waitqueue_head(&i2c_imx->queue); > > @@ -1195,6 +1187,14 @@ static int i2c_imx_probe(struct platform_device *pdev) > if (ret < 0) > goto rpm_disable; > > + /* Request IRQ */ > + ret = request_threaded_irq(irq, i2c_imx_isr, NULL, IRQF_SHARED, > + pdev->name, i2c_imx); > + if (ret) { > + dev_err(&pdev->dev, "can't claim irq %d\n", irq); > + goto rpm_disable; > + } > + > /* Set up clock divider */ > i2c_imx->bitrate = I2C_MAX_STANDARD_MODE_FREQ; > ret = of_property_read_u32(pdev->dev.of_node, > @@ -1237,13 +1237,12 @@ static int i2c_imx_probe(struct platform_device *pdev) > > clk_notifier_unregister: > clk_notifier_unregister(i2c_imx->clk, &i2c_imx->clk_change_nb); > + free_irq(irq, i2c_imx); > rpm_disable: > pm_runtime_put_noidle(&pdev->dev); > pm_runtime_disable(&pdev->dev); > pm_runtime_set_suspended(&pdev->dev); > pm_runtime_dont_use_autosuspend(&pdev->dev); > - > -clk_disable: > clk_disable_unprepare(i2c_imx->clk); > return ret; > } > @@ -1251,7 +1250,7 @@ static int i2c_imx_probe(struct platform_device *pdev) > static int i2c_imx_remove(struct platform_device *pdev) > { > struct imx_i2c_struct *i2c_imx = platform_get_drvdata(pdev); > - int ret; > + int irq, ret; > > ret = pm_runtime_get_sync(&pdev->dev); > if (ret < 0) > @@ -1271,6 +1270,9 @@ static int i2c_imx_remove(struct platform_device *pdev) > imx_i2c_write_reg(0, i2c_imx, IMX_I2C_I2SR); > > clk_notifier_unregister(i2c_imx->clk, &i2c_imx->clk_change_nb); > + irq = platform_get_irq(pdev, 0); > + if (irq >= 0) > + free_irq(irq, i2c_imx); > clk_disable_unprepare(i2c_imx->clk); > > pm_runtime_put_noidle(&pdev->dev); > -- > 2.17.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |