Linux-i2c Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for the oneplus6
       [not found] <20201007174736.292968-1-caleb@connolly.tech>
@ 2020-10-07 17:49 ` Caleb Connolly
  2020-10-08 10:03   ` Wolfram Sang
  2020-10-09  5:26   ` Akash Asthana
  0 siblings, 2 replies; 8+ messages in thread
From: Caleb Connolly @ 2020-10-07 17:49 UTC (permalink / raw)
  To: linux-arm-msm, Andy Gross, Bjorn Andersson, Akash Asthana,
	Mukesh Savaliya
  Cc: ~postmarketos/upstreaming, Caleb Connolly, linux-i2c, linux-kernel

The OnePlus 6/T has the same issues as the c630 causing a crash when DMA
is used for i2c, so disable it.

https://patchwork.kernel.org/patch/11133827/
Signed-off-by: Caleb Connolly <caleb@connolly.tech>
---
 drivers/i2c/busses/i2c-qcom-geni.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
index dead5db3315a..50a0674a6553 100644
--- a/drivers/i2c/busses/i2c-qcom-geni.c
+++ b/drivers/i2c/busses/i2c-qcom-geni.c
@@ -358,7 +358,8 @@ static int geni_i2c_rx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg,
 	struct geni_se *se = &gi2c->se;
 	size_t len = msg->len;
 
-	if (!of_machine_is_compatible("lenovo,yoga-c630"))
+	if (!of_machine_is_compatible("lenovo,yoga-c630") &&
+	    !of_machine_is_compatible("oneplus,oneplus6"))
 		dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
 
 	if (dma_buf)
@@ -400,7 +401,8 @@ static int geni_i2c_tx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg,
 	struct geni_se *se = &gi2c->se;
 	size_t len = msg->len;
 
-	if (!of_machine_is_compatible("lenovo,yoga-c630"))
+	if (!of_machine_is_compatible("lenovo,yoga-c630") &&
+	    !of_machine_is_compatible("oneplus,oneplus6"))
 		dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
 
 	if (dma_buf)
-- 
2.28.0



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for the oneplus6
  2020-10-07 17:49 ` [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for the oneplus6 Caleb Connolly
@ 2020-10-08 10:03   ` Wolfram Sang
  2020-10-08 10:46     ` Caleb Connolly
  2020-10-09  6:53     ` Mukesh, Savaliya
  2020-10-09  5:26   ` Akash Asthana
  1 sibling, 2 replies; 8+ messages in thread
From: Wolfram Sang @ 2020-10-08 10:03 UTC (permalink / raw)
  To: Caleb Connolly
  Cc: linux-arm-msm, Andy Gross, Bjorn Andersson, Akash Asthana,
	Mukesh Savaliya, ~postmarketos/upstreaming, linux-i2c,
	linux-kernel


[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]

On Wed, Oct 07, 2020 at 05:49:35PM +0000, Caleb Connolly wrote:
> The OnePlus 6/T has the same issues as the c630 causing a crash when DMA
> is used for i2c, so disable it.
> 
> https://patchwork.kernel.org/patch/11133827/
> Signed-off-by: Caleb Connolly <caleb@connolly.tech>

May I ask for a quick review here, so we can get this into 5.9 if
qcom-geni maintainers agree this is good to go?

> ---
>  drivers/i2c/busses/i2c-qcom-geni.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
> index dead5db3315a..50a0674a6553 100644
> --- a/drivers/i2c/busses/i2c-qcom-geni.c
> +++ b/drivers/i2c/busses/i2c-qcom-geni.c
> @@ -358,7 +358,8 @@ static int geni_i2c_rx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg,
>  	struct geni_se *se = &gi2c->se;
>  	size_t len = msg->len;
>  
> -	if (!of_machine_is_compatible("lenovo,yoga-c630"))
> +	if (!of_machine_is_compatible("lenovo,yoga-c630") &&
> +	    !of_machine_is_compatible("oneplus,oneplus6"))
>  		dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
>  
>  	if (dma_buf)
> @@ -400,7 +401,8 @@ static int geni_i2c_tx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg,
>  	struct geni_se *se = &gi2c->se;
>  	size_t len = msg->len;
>  
> -	if (!of_machine_is_compatible("lenovo,yoga-c630"))
> +	if (!of_machine_is_compatible("lenovo,yoga-c630") &&
> +	    !of_machine_is_compatible("oneplus,oneplus6"))
>  		dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
>  
>  	if (dma_buf)
> -- 
> 2.28.0
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Re: [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for the oneplus6
  2020-10-08 10:03   ` Wolfram Sang
@ 2020-10-08 10:46     ` Caleb Connolly
  2020-10-08 12:19       ` Wolfram Sang
  2020-10-09  6:53     ` Mukesh, Savaliya
  1 sibling, 1 reply; 8+ messages in thread
From: Caleb Connolly @ 2020-10-08 10:46 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: linux-arm-msm, Andy Gross, Bjorn Andersson, Akash Asthana,
	Mukesh Savaliya, ~postmarketos/upstreaming, linux-i2c,
	linux-kernel

On 2020-10-08 11:03, Wolfram Sang wrote:
> On Wed, Oct 07, 2020 at 05:49:35PM +0000, Caleb Connolly wrote:
>> The OnePlus 6/T has the same issues as the c630 causing a crash when DMA
>> is used for i2c, so disable it.
>>
>> https://patchwork.kernel.org/patch/11133827/
>> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
> May I ask for a quick review here, so we can get this into 5.9 if
> qcom-geni maintainers agree this is good to go?

Sorry it wasn't mentioned in my first message, this patch depends on the 
rest in the series found here: 
https://lore.kernel.org/linux-arm-msm/20201007174736.292968-1-caleb@connolly.tech/#r

>> ---
>>   drivers/i2c/busses/i2c-qcom-geni.c | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
>> index dead5db3315a..50a0674a6553 100644
>> --- a/drivers/i2c/busses/i2c-qcom-geni.c
>> +++ b/drivers/i2c/busses/i2c-qcom-geni.c
>> @@ -358,7 +358,8 @@ static int geni_i2c_rx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg,
>>   	struct geni_se *se = &gi2c->se;
>>   	size_t len = msg->len;
>>   
>> -	if (!of_machine_is_compatible("lenovo,yoga-c630"))
>> +	if (!of_machine_is_compatible("lenovo,yoga-c630") &&
>> +	    !of_machine_is_compatible("oneplus,oneplus6"))
>>   		dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
>>   
>>   	if (dma_buf)
>> @@ -400,7 +401,8 @@ static int geni_i2c_tx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg,
>>   	struct geni_se *se = &gi2c->se;
>>   	size_t len = msg->len;
>>   
>> -	if (!of_machine_is_compatible("lenovo,yoga-c630"))
>> +	if (!of_machine_is_compatible("lenovo,yoga-c630") &&
>> +	    !of_machine_is_compatible("oneplus,oneplus6"))
>>   		dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
>>   
>>   	if (dma_buf)
>> -- 
>> 2.28.0
>>
>>



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Re: [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for the oneplus6
  2020-10-08 10:46     ` Caleb Connolly
@ 2020-10-08 12:19       ` Wolfram Sang
  0 siblings, 0 replies; 8+ messages in thread
From: Wolfram Sang @ 2020-10-08 12:19 UTC (permalink / raw)
  To: Caleb Connolly
  Cc: linux-arm-msm, Andy Gross, Bjorn Andersson, Akash Asthana,
	Mukesh Savaliya, ~postmarketos/upstreaming, linux-i2c,
	linux-kernel


[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

On Thu, Oct 08, 2020 at 10:46:05AM +0000, Caleb Connolly wrote:
> On 2020-10-08 11:03, Wolfram Sang wrote:
> > On Wed, Oct 07, 2020 at 05:49:35PM +0000, Caleb Connolly wrote:
> >> The OnePlus 6/T has the same issues as the c630 causing a crash when DMA
> >> is used for i2c, so disable it.
> >>
> >> https://patchwork.kernel.org/patch/11133827/
> >> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
> > May I ask for a quick review here, so we can get this into 5.9 if
> > qcom-geni maintainers agree this is good to go?
> 
> Sorry it wasn't mentioned in my first message, this patch depends on the 
> rest in the series found here: 
> https://lore.kernel.org/linux-arm-msm/20201007174736.292968-1-caleb@connolly.tech/#r

Ah, so the device is not upstream yet and there is no hurry. Good to
know. Thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for the oneplus6
  2020-10-07 17:49 ` [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for the oneplus6 Caleb Connolly
  2020-10-08 10:03   ` Wolfram Sang
@ 2020-10-09  5:26   ` Akash Asthana
  2020-10-09  5:58     ` Wolfram Sang
  1 sibling, 1 reply; 8+ messages in thread
From: Akash Asthana @ 2020-10-09  5:26 UTC (permalink / raw)
  To: Caleb Connolly, linux-arm-msm, Andy Gross, Bjorn Andersson,
	Mukesh Savaliya
  Cc: ~postmarketos/upstreaming, linux-i2c, linux-kernel

On 10/7/2020 11:19 PM, Caleb Connolly wrote:
> The OnePlus 6/T has the same issues as the c630 causing a crash when DMA
> is used for i2c, so disable it.
>
> https://patchwork.kernel.org/patch/11133827

Reviewed-by: Akash Asthana <akashast@codeaurora.org>

> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
> ---
>   drivers/i2c/busses/i2c-qcom-geni.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
> index dead5db3315a..50a0674a6553 100644
> --- a/drivers/i2c/busses/i2c-qcom-geni.c
> +++ b/drivers/i2c/busses/i2c-qcom-geni.c
> @@ -358,7 +358,8 @@ static int geni_i2c_rx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg,
>   	struct geni_se *se = &gi2c->se;
>   	size_t len = msg->len;
>   
> -	if (!of_machine_is_compatible("lenovo,yoga-c630"))
> +	if (!of_machine_is_compatible("lenovo,yoga-c630") &&
> +	    !of_machine_is_compatible("oneplus,oneplus6"))
>   		dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
>   
>   	if (dma_buf)
> @@ -400,7 +401,8 @@ static int geni_i2c_tx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg,
>   	struct geni_se *se = &gi2c->se;
>   	size_t len = msg->len;
>   
> -	if (!of_machine_is_compatible("lenovo,yoga-c630"))
> +	if (!of_machine_is_compatible("lenovo,yoga-c630") &&
> +	    !of_machine_is_compatible("oneplus,oneplus6"))
>   		dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
>   
>   	if (dma_buf)

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for the oneplus6
  2020-10-09  5:26   ` Akash Asthana
@ 2020-10-09  5:58     ` Wolfram Sang
  0 siblings, 0 replies; 8+ messages in thread
From: Wolfram Sang @ 2020-10-09  5:58 UTC (permalink / raw)
  To: Akash Asthana
  Cc: Caleb Connolly, linux-arm-msm, Andy Gross, Bjorn Andersson,
	Mukesh Savaliya, ~postmarketos/upstreaming, linux-i2c,
	linux-kernel


[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

On Fri, Oct 09, 2020 at 10:56:15AM +0530, Akash Asthana wrote:
> On 10/7/2020 11:19 PM, Caleb Connolly wrote:
> > The OnePlus 6/T has the same issues as the c630 causing a crash when DMA
> > is used for i2c, so disable it.
> > 
> > https://patchwork.kernel.org/patch/11133827
> 
> Reviewed-by: Akash Asthana <akashast@codeaurora.org>

Thanks!

Acked-by: Wolfram Sang <wsa@kernel.org>

So, this patch can go in via whatever tree seems apropriate. Let me know
if I should take this patch individually.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for the oneplus6
  2020-10-08 10:03   ` Wolfram Sang
  2020-10-08 10:46     ` Caleb Connolly
@ 2020-10-09  6:53     ` Mukesh, Savaliya
  1 sibling, 0 replies; 8+ messages in thread
From: Mukesh, Savaliya @ 2020-10-09  6:53 UTC (permalink / raw)
  To: Wolfram Sang, Caleb Connolly
  Cc: linux-arm-msm, Andy Gross, Bjorn Andersson, Akash Asthana,
	~postmarketos/upstreaming, linux-i2c, linux-kernel


On 10/8/2020 3:33 PM, Wolfram Sang wrote:
> On Wed, Oct 07, 2020 at 05:49:35PM +0000, Caleb Connolly wrote:
>> The OnePlus 6/T has the same issues as the c630 causing a crash when DMA
>> is used for i2c, so disable it.
>>
>> https://patchwork.kernel.org/patch/11133827/
>> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
Reviewed-by: Mukesh Kumar Savaliya <msavaliy@codeaurora.org>
> May I ask for a quick review here, so we can get this into 5.9 if
> qcom-geni maintainers agree this is good to go?
>
>> ---
>>   drivers/i2c/busses/i2c-qcom-geni.c | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
>> index dead5db3315a..50a0674a6553 100644
>> --- a/drivers/i2c/busses/i2c-qcom-geni.c
>> +++ b/drivers/i2c/busses/i2c-qcom-geni.c
>> @@ -358,7 +358,8 @@ static int geni_i2c_rx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg,
>>   	struct geni_se *se = &gi2c->se;
>>   	size_t len = msg->len;
>>   
>> -	if (!of_machine_is_compatible("lenovo,yoga-c630"))
>> +	if (!of_machine_is_compatible("lenovo,yoga-c630") &&
>> +	    !of_machine_is_compatible("oneplus,oneplus6"))
>>   		dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
>>   
>>   	if (dma_buf)
>> @@ -400,7 +401,8 @@ static int geni_i2c_tx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg,
>>   	struct geni_se *se = &gi2c->se;
>>   	size_t len = msg->len;
>>   
>> -	if (!of_machine_is_compatible("lenovo,yoga-c630"))
>> +	if (!of_machine_is_compatible("lenovo,yoga-c630") &&
>> +	    !of_machine_is_compatible("oneplus,oneplus6"))
>>   		dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
>>   
>>   	if (dma_buf)
>> -- 
>> 2.28.0
>>
>>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for the oneplus6
       [not found] <20201007171807.285298-1-caleb@connolly.tech>
@ 2020-10-07 17:20 ` Caleb Connolly
  0 siblings, 0 replies; 8+ messages in thread
From: Caleb Connolly @ 2020-10-07 17:20 UTC (permalink / raw)
  To: Akash Asthana, Mukesh Savaliya, Andy Gross, Bjorn Andersson
  Cc: ~postmarketos/upstreaming, Caleb Connolly, linux-i2c,
	linux-arm-msm, linux-kernel

The OnePlus 6/T has the same issues as the c630 causing a crash when DMA
is used for i2c, so disable it.

https://patchwork.kernel.org/patch/11133827/
Signed-off-by: Caleb Connolly <caleb@connolly.tech>
---
 drivers/i2c/busses/i2c-qcom-geni.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
index dead5db3315a..50a0674a6553 100644
--- a/drivers/i2c/busses/i2c-qcom-geni.c
+++ b/drivers/i2c/busses/i2c-qcom-geni.c
@@ -358,7 +358,8 @@ static int geni_i2c_rx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg,
 	struct geni_se *se = &gi2c->se;
 	size_t len = msg->len;
 
-	if (!of_machine_is_compatible("lenovo,yoga-c630"))
+	if (!of_machine_is_compatible("lenovo,yoga-c630") &&
+	    !of_machine_is_compatible("oneplus,oneplus6"))
 		dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
 
 	if (dma_buf)
@@ -400,7 +401,8 @@ static int geni_i2c_tx_one_msg(struct geni_i2c_dev *gi2c, struct i2c_msg *msg,
 	struct geni_se *se = &gi2c->se;
 	size_t len = msg->len;
 
-	if (!of_machine_is_compatible("lenovo,yoga-c630"))
+	if (!of_machine_is_compatible("lenovo,yoga-c630") &&
+	    !of_machine_is_compatible("oneplus,oneplus6"))
 		dma_buf = i2c_get_dma_safe_msg_buf(msg, 32);
 
 	if (dma_buf)
-- 
2.28.0



^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, back to index

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20201007174736.292968-1-caleb@connolly.tech>
2020-10-07 17:49 ` [PATCH 5/5] i2c: geni: sdm845: dont perform DMA for the oneplus6 Caleb Connolly
2020-10-08 10:03   ` Wolfram Sang
2020-10-08 10:46     ` Caleb Connolly
2020-10-08 12:19       ` Wolfram Sang
2020-10-09  6:53     ` Mukesh, Savaliya
2020-10-09  5:26   ` Akash Asthana
2020-10-09  5:58     ` Wolfram Sang
     [not found] <20201007171807.285298-1-caleb@connolly.tech>
2020-10-07 17:20 ` Caleb Connolly

Linux-i2c Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-i2c/0 linux-i2c/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-i2c linux-i2c/ https://lore.kernel.org/linux-i2c \
		linux-i2c@vger.kernel.org
	public-inbox-index linux-i2c

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-i2c


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git