From: Sascha Hauer <sha@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux@rempel-privat.de, wsa@kernel.org,
linux-i2c@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] i2c: imx: Remove unused .id_table support
Date: Tue, 19 Jan 2021 09:47:45 +0100 [thread overview]
Message-ID: <20210119084745.GS19063@pengutronix.de> (raw)
In-Reply-To: <20210119003148.1793614-1-festevam@gmail.com>
Hi Fabio,
On Mon, Jan 18, 2021 at 09:31:47PM -0300, Fabio Estevam wrote:
> Since 5.10-rc1 i.MX is a devicetree-only platform and the existing
> .id_table support in this driver was only useful for old non-devicetree
> platforms.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> drivers/i2c/busses/i2c-imx.c | 20 +-------------------
> 1 file changed, 1 insertion(+), 19 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index c98529c76348..ebf66120c51e 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -233,19 +233,6 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata = {
>
> };
>
> -static const struct platform_device_id imx_i2c_devtype[] = {
> - {
> - .name = "imx1-i2c",
> - .driver_data = (kernel_ulong_t)&imx1_i2c_hwdata,
> - }, {
Please grep for the driver name instead of guessing that it is unused.
This driver is indeed used with platform binding in the coldfire
architecture.
Regards,
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2021-01-19 8:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 0:31 [PATCH] i2c: imx: Remove unused .id_table support Fabio Estevam
2021-01-19 0:31 ` [PATCH 2/2] i2c: imx: Remove unneeded 'match' variable Fabio Estevam
2021-01-19 8:47 ` Sascha Hauer [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-11-16 20:29 [PATCH] i2c: imx: Remove unused .id_table support Fabio Estevam
2020-11-17 7:01 ` Uwe Kleine-König
2020-12-02 15:46 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119084745.GS19063@pengutronix.de \
--to=sha@pengutronix.de \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).