linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: Youling Tang <tangyouling@loongson.cn>
Cc: Seth Heasley <seth.heasley@intel.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] i2c: ismt: Use dma_set_mask_and_coherent
Date: Fri, 22 Jan 2021 10:07:37 +0100	[thread overview]
Message-ID: <20210122090737.GG858@kunai> (raw)
In-Reply-To: <1606978252-26169-1-git-send-email-tangyouling@loongson.cn>

[-- Attachment #1: Type: text/plain, Size: 1527 bytes --]

On Thu, Dec 03, 2020 at 02:50:52PM +0800, Youling Tang wrote:
> 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by
> an equivalent 'dma_set_mask_and_coherent()' which is much less verbose.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Youling Tang <tangyouling@loongson.cn>

Seth, Neil, are you OK with this patch?

> ---
> 
> v3: Fix build errors of incompatible pointer types.
> 
>  drivers/i2c/busses/i2c-ismt.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
> index a35a27c..88f6039 100644
> --- a/drivers/i2c/busses/i2c-ismt.c
> +++ b/drivers/i2c/busses/i2c-ismt.c
> @@ -903,16 +903,12 @@ ismt_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  		return -ENODEV;
>  	}
>  
> -	if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(64)) != 0) ||
> -	    (pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64)) != 0)) {
> -		if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(32)) != 0) ||
> -		    (pci_set_consistent_dma_mask(pdev,
> -						 DMA_BIT_MASK(32)) != 0)) {
> -			dev_err(&pdev->dev, "pci_set_dma_mask fail %p\n",
> +	if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)) != 0)
> +		if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)) != 0) {
> +			dev_err(&pdev->dev, "dma_set_mask_and_coherent fail %p\n",
>  				pdev);
>  			return -ENODEV;
>  		}
> -	}
>  
>  	err = ismt_dev_init(priv);
>  	if (err)
> -- 
> 2.1.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2021-01-22 12:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03  6:50 [PATCH v3] i2c: ismt: Use dma_set_mask_and_coherent Youling Tang
2021-01-22  9:07 ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210122090737.GG858@kunai \
    --to=wsa@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=seth.heasley@intel.com \
    --cc=tangyouling@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).