From: Wolfram Sang <wsa@kernel.org>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Jean Delvare <jdelvare@suse.de>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: i801: Add support for Intel Alder Lake PCH-P
Date: Thu, 28 Jan 2021 09:59:43 +0100 [thread overview]
Message-ID: <20210128085943.GD963@ninjato> (raw)
In-Reply-To: <20210114143811.1820137-1-jarkko.nikula@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 2248 bytes --]
On Thu, Jan 14, 2021 at 04:38:11PM +0200, Jarkko Nikula wrote:
> Add PCI ID of SMBus controller on Intel Alder Lake PCH-P.
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Do we still update Documentation/i2c/busses/i2c-i801.rst?
And maybe we should add Jarkko as i801 maintainer because Jean is usually
fine with such changes?
> ---
> drivers/i2c/busses/i2c-i801.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index 4435e5fdc75e..b931b629b457 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -73,6 +73,7 @@
> * Jasper Lake (SOC) 0x4da3 32 hard yes yes yes
> * Comet Lake-V (PCH) 0xa3a3 32 hard yes yes yes
> * Alder Lake-S (PCH) 0x7aa3 32 hard yes yes yes
> + * Alder Lake-P (PCH) 0x51a3 32 hard yes yes yes
> *
> * Features supported by this driver:
> * Software PEC no
> @@ -230,6 +231,7 @@
> #define PCI_DEVICE_ID_INTEL_TIGERLAKE_H_SMBUS 0x43a3
> #define PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS 0x4b23
> #define PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS 0x4da3
> +#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_P_SMBUS 0x51a3
> #define PCI_DEVICE_ID_INTEL_BROXTON_SMBUS 0x5ad4
> #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS 0x7aa3
> #define PCI_DEVICE_ID_INTEL_LYNXPOINT_SMBUS 0x8c22
> @@ -1087,6 +1089,7 @@ static const struct pci_device_id i801_ids[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TIGERLAKE_H_SMBUS) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS) },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS) },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ALDER_LAKE_P_SMBUS) },
> { 0, }
> };
>
> @@ -1776,6 +1779,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
> case PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS:
> case PCI_DEVICE_ID_INTEL_EBG_SMBUS:
> case PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS:
> + case PCI_DEVICE_ID_INTEL_ALDER_LAKE_P_SMBUS:
> priv->features |= FEATURE_BLOCK_PROC;
> priv->features |= FEATURE_I2C_BLOCK_READ;
> priv->features |= FEATURE_IRQ;
> --
> 2.29.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-01-28 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 14:38 [PATCH] i2c: i801: Add support for Intel Alder Lake PCH-P Jarkko Nikula
2021-01-28 8:59 ` Wolfram Sang [this message]
2021-02-01 14:02 ` Jarkko Nikula
2021-02-09 10:45 ` Wolfram Sang
2021-02-26 16:35 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128085943.GD963@ninjato \
--to=wsa@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).