From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D697C433E6 for ; Wed, 10 Mar 2021 10:36:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B1BDC64F51 for ; Wed, 10 Mar 2021 10:36:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231828AbhCJKfw (ORCPT ); Wed, 10 Mar 2021 05:35:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231790AbhCJKfn (ORCPT ); Wed, 10 Mar 2021 05:35:43 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6FADC06174A for ; Wed, 10 Mar 2021 02:35:42 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id w7so6762479wmb.5 for ; Wed, 10 Mar 2021 02:35:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=k11X2IaCm7778Ql6a7D/ZiOxFU1ZEqfWNW+eBOH3OF8=; b=KqK258d2QHv7GjqtjRSg40t0WuJXZB5TC4pmhS1sfVUud9iiq28hZscR/pYRDHADt0 3ngif1VVcCFN8W1KFj+FJyByX89v1XlrNRu8Eqb2rPMS+/v8ikJKCriSIsrUyqrR9AAI c/GKw6xIW0xrZJG8H2KBpJceqc2IY27Xa6mvV05UpaMYS+AuN396IIJMfNFvOAT9A7Xi JeRgMOTNcd5VHfj2Ud3g4Spjf4QtlbhPNy1saLLdxmgNJnvOVfcHj5TKfQ+tbPFQuNh6 eZLrxAG5qs2Gfx+JWUCGv0at9m45ur7leVzSQBAkzg+Oke4Cftu8w80ZEcURiQOnV1jw hJvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=k11X2IaCm7778Ql6a7D/ZiOxFU1ZEqfWNW+eBOH3OF8=; b=IyhZhoS5BsL279ijIAvxHgjaJdCjk9xsLU3tOHH75h993ZTywpE1MVE028pLVhN3Cd 4Usp+168/kWUTiOjQ6guBPyDk6rwH2BhzoztmN8iFVYiTLbYby6k//VMh7CHHA3PwhtQ j54WvSiq0G1iHVXDd7nwSE4kdhJrOT+Hh5bGRnEk2LilSszIH33hXix5X6RSJN84uHN/ C+U4dz+Vc/YQfH+sP7F4Nqr9uzctMs6WcJTRuVIF9U9/Um+UZYKrLrqSfP62h3L5WOmL tRDCCKAwrm6IEXfckmG9SBs0kyKzJ72z7HoU10o24yuCTIXi8eHU+vbMBaXiH/aIZx14 yplg== X-Gm-Message-State: AOAM53039M2w4YfPGeU0xq1xOo5umzxsqSBqW4xqPJWxYDzXT250z7KY bXNEJ1t18kCawaUDj6gw6dshOg== X-Google-Smtp-Source: ABdhPJyLdOIr4E9Qa53UvZvv/KO6KjoXTUQ6/+YP6LjE0pSDSgp7inNcVk00mLbhh5ugPQI+9vacOg== X-Received: by 2002:a05:600c:47d7:: with SMTP id l23mr2682273wmo.155.1615372541428; Wed, 10 Mar 2021 02:35:41 -0800 (PST) Received: from dell ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id s3sm2307358wmd.21.2021.03.10.02.35.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 02:35:41 -0800 (PST) Date: Wed, 10 Mar 2021 10:35:39 +0000 From: Lee Jones To: Andy Shevchenko Cc: Wolfram Sang , Jean Delvare , Tan Jui Nee , Jim Quinlan , Jonathan Yong , Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, Jean Delvare , Peter Tyser , hdegoede@redhat.com, henning.schild@siemens.com Subject: Re: [PATCH v1 5/7] mfd: lpc_ich: Switch to generic pci_p2sb_bar() Message-ID: <20210310103539.GF701493@dell> References: <20210308122020.57071-1-andriy.shevchenko@linux.intel.com> <20210308122020.57071-6-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210308122020.57071-6-andriy.shevchenko@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Mon, 08 Mar 2021, Andy Shevchenko wrote: > Instead of open coding pci_p2sb_bar() functionality we are going to > use generic library for that. There one more user of it is coming. > > Besides cleaning up it fixes a potential issue if, by some reason, > SPI bar is 64-bit. Probably worth cleaning up the English in both these sections. Instead of open coding pci_p2sb_bar() functionality we are going to use generic library. There is one more user en route. This is more than just a clean-up. It also fixes a potential issue seen when SPI bar is 64-bit. Also worth briefly describing what that issue is I think. > Signed-off-by: Andy Shevchenko > --- > drivers/mfd/Kconfig | 1 + > drivers/mfd/lpc_ich.c | 20 ++++++-------------- > 2 files changed, 7 insertions(+), 14 deletions(-) Code looks fine: For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog