From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49F7EC433E6 for ; Wed, 10 Mar 2021 12:58:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B23964FFA for ; Wed, 10 Mar 2021 12:58:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231272AbhCJM5k (ORCPT ); Wed, 10 Mar 2021 07:57:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232073AbhCJM5a (ORCPT ); Wed, 10 Mar 2021 07:57:30 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF14EC061760 for ; Wed, 10 Mar 2021 04:57:29 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id d15so23219534wrv.5 for ; Wed, 10 Mar 2021 04:57:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=cTMvOE1aY9tYXdGR+TBQv9AHcsTzbR2H/zyw8rY1gFg=; b=voDChAePN3lGcrI+g15hdroCEK19w9WwMjBdiBbBV4/seg/y5UOOG69R6m8xrqITQl rCLhxWlbdBRREwbtvKGAqfhSVA1jSkWufntZUX87g3R+qI1yBCITczkoDxwLFH1zp/nL YAiCniEegwIQD/4zs/JCuIwO5JjV3w5IUifu6xT/tmRbmoMUPPxYZrn/GfkOY2vJiohH anofs2ni8L7kkhd8IYYYoCtg2CwgH24OUYtZZ5lwjwFmLydKlKiWLtwJ3aMkKCvc/NnH UHr3awiKzo/YSG6ZOn0kh64cs3RaZwulewChFglI7winAthP4vJG61RbR+rdP4xODIwQ 4bXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=cTMvOE1aY9tYXdGR+TBQv9AHcsTzbR2H/zyw8rY1gFg=; b=q2lT5CODiixECFpQGs/WCU8E4EkuULPMAJzqGW+NhzbODgdK8NY39uah64V3eUSRVk ENf4dJnCjrnap3Mc7XAyELI5/OZ1WGtvpphNoTmX/XS9epS7Msx4VX+2GFrtPbh96YfY srJKQCFU4Z5UManTpv/6LXjFRSv9JWqni0HQJ33u4MMSI1+1E4ccOjRwXpqTJCAm2Bzs Gn1/Inyo/leeRxnAGfPv6/8q5tIc6BxfqHv3TZtx74WIRFc+Lj55u1+yOa1s+8F5rynd zwS+LqY/V9LT5vN4oRHIgt8xxqZBtnBJHz4Gc72gnmMmHF0zPxhLrJEoOzPbSFLeCnH9 lTgA== X-Gm-Message-State: AOAM533HHk+kzMfIUiJrKENgGSn3XZgQ5/QBn65ksPJmujjmgFm3UXnN 9ZJOotJggyc4NZpCcg3Rbd1n1w== X-Google-Smtp-Source: ABdhPJyv42ta79+HXX9BNbdmsCVAhY3y637uTADEZywR/B0pQOav2a1BH/4Zw/b8IUR9gERxOpmtbw== X-Received: by 2002:a5d:4341:: with SMTP id u1mr3503760wrr.88.1615381048726; Wed, 10 Mar 2021 04:57:28 -0800 (PST) Received: from dell ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id l8sm30063213wrx.83.2021.03.10.04.57.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 04:57:28 -0800 (PST) Date: Wed, 10 Mar 2021 12:57:26 +0000 From: Lee Jones To: Andy Shevchenko Cc: Wolfram Sang , Jean Delvare , Tan Jui Nee , Jim Quinlan , Jonathan Yong , Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, Jean Delvare , Peter Tyser , hdegoede@redhat.com, henning.schild@siemens.com Subject: Re: [PATCH v1 5/7] mfd: lpc_ich: Switch to generic pci_p2sb_bar() Message-ID: <20210310125726.GO701493@dell> References: <20210308122020.57071-1-andriy.shevchenko@linux.intel.com> <20210308122020.57071-6-andriy.shevchenko@linux.intel.com> <20210310103539.GF701493@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Wed, 10 Mar 2021, Andy Shevchenko wrote: > On Wed, Mar 10, 2021 at 10:35:39AM +0000, Lee Jones wrote: > > On Mon, 08 Mar 2021, Andy Shevchenko wrote: > > > > > Instead of open coding pci_p2sb_bar() functionality we are going to > > > use generic library for that. There one more user of it is coming. > > > > > > Besides cleaning up it fixes a potential issue if, by some reason, > > > SPI bar is 64-bit. > > > > Probably worth cleaning up the English in both these sections. > > > > Instead of open coding pci_p2sb_bar() functionality we are going to > > use generic library. There is one more user en route. > > > > This is more than just a clean-up. It also fixes a potential issue > > seen when SPI bar is 64-bit. > > Thanks! > > > Also worth briefly describing what that issue is I think. > > Current code works if and only if the PCI BAR of the hidden device is inside 4G > address space. In case firmware decides to go above 4G, we will get a wrong > address. > > Does it sound good enough? Yes, that explains it, thanks. > > > Signed-off-by: Andy Shevchenko > > > --- > > > drivers/mfd/Kconfig | 1 + > > > drivers/mfd/lpc_ich.c | 20 ++++++-------------- > > > 2 files changed, 7 insertions(+), 14 deletions(-) > > > > Code looks fine: > > > > For my own reference (apply this as-is to your sign-off block): > > > > Acked-for-MFD-by: Lee Jones > > Thanks for reviewing this series, can you have a look at the earlier sent [1] > and [2]? First one has a regression fix. Yes, thanks for the nudge. These were not in my TODO list. > [1]: https://lore.kernel.org/lkml/20210302135620.89958-1-andriy.shevchenko@linux.intel.com/T/#u > [2]: https://lore.kernel.org/lkml/20210301144222.31290-1-andriy.shevchenko@linux.intel.com/T/#u > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog