linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"linux@roeck-us.net" <linux@roeck-us.net>,
	"wsa@kernel.org" <wsa@kernel.org>,
	"jdelvare@suse.com" <jdelvare@suse.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/6] dt-bindings: i2c: convert i2c-mpc to json-schema
Date: Tue, 23 Mar 2021 15:10:35 -0600	[thread overview]
Message-ID: <20210323211035.GA1326908@robh.at.kernel.org> (raw)
In-Reply-To: <f5e86696-07f1-f1d2-9596-af7fa6ae1cdd@alliedtelesis.co.nz>

On Tue, Mar 23, 2021 at 08:22:00PM +0000, Chris Packham wrote:
> Hi Rob,
> 
> On 24/03/21 9:16 am, Rob Herring wrote:
> > On Tue, 23 Mar 2021 17:33:27 +1300, Chris Packham wrote:
> >> Convert i2c-mpc to YAML.
> >>
> >> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> >> ---
> >>   .../devicetree/bindings/i2c/i2c-mpc.txt       | 62 ------------
> >>   .../devicetree/bindings/i2c/i2c-mpc.yaml      | 99 +++++++++++++++++++
> >>   2 files changed, 99 insertions(+), 62 deletions(-)
> >>   delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-mpc.txt
> >>   create mode 100644 Documentation/devicetree/bindings/i2c/i2c-mpc.yaml
> >>
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> > ./Documentation/devicetree/bindings/i2c/i2c-mpc.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> > ./Documentation/devicetree/bindings/i2c/i2c-mpc.yaml:20:11: [warning] wrong indentation: expected 12 but found 10 (indentation)
> Hmm I did run 'make dt_binding_check' is yamllint run separately (or not 
> run if it's not installed?).

No and yes...

> > dtschema/dtc warnings/errors:
> >
> > See https://patchwork.ozlabs.org/patch/1457053
> >
> > This check can fail if there are any dependencies. The base for a patch
> > series is generally the most recent rc1.
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:

^^^^^

> >
> > pip3 install dtschema --upgrade
> >
> > Please check and re-submit.
> Should be easy to fix the binding but I'll spend a bit of time trying to 
> get my tooling sorted.

  reply	other threads:[~2021-03-23 21:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23  4:33 [PATCH 0/6] i2c: mpc: Refactor to improve responsiveness Chris Packham
2021-03-23  4:33 ` [PATCH 1/6] dt-bindings: i2c-mpc: Document interrupt property as required Chris Packham
2021-03-23  4:33 ` [PATCH 2/6] dt-bindings: i2c: convert i2c-mpc to json-schema Chris Packham
2021-03-23 20:16   ` Rob Herring
2021-03-23 20:22     ` Chris Packham
2021-03-23 21:10       ` Rob Herring [this message]
2021-03-23 21:15   ` Rob Herring
2021-03-23 21:59     ` Chris Packham
2021-03-24  3:36       ` Chris Packham
2021-03-27 17:18         ` Rob Herring
2021-03-23  4:33 ` [PATCH 3/6] i2c: mpc: Make use of i2c_recover_bus() Chris Packham
2021-03-23  4:33 ` [PATCH 4/6] i2c: mpc: make interrupt mandatory and remove polling code Chris Packham
2021-03-23  4:33 ` [PATCH 5/6] i2c: mpc: use device managed APIs Chris Packham
2021-03-23  4:33 ` [PATCH 6/6] i2c: mpc: Interrupt driven transfer Chris Packham
2021-03-24  3:43 ` [PATCH 0/6] i2c: mpc: Refactor to improve responsiveness Chris Packham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210323211035.GA1326908@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=Chris.Packham@alliedtelesis.co.nz \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).