> + priv->irq = ret = platform_get_irq(pdev, 0); Please no double assignments. Otherwise good catch!