Linux-i2c Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] i2c: sprd: Add missing MODULE_DEVICE_TABLE
@ 2021-04-10  3:50 Bixuan Cui
  2021-04-12 14:04 ` Baolin Wang
  2021-04-13 12:35 ` Wolfram Sang
  0 siblings, 2 replies; 3+ messages in thread
From: Bixuan Cui @ 2021-04-10  3:50 UTC (permalink / raw)
  To: cuibixuan, Orson Zhai, Baolin Wang, Chunyan Zhang, Wolfram Sang,
	Andy Shevchenko, Dejin Zheng, Linhua Xu
  Cc: linux-i2c, kernel-janitors

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
---
 drivers/i2c/busses/i2c-sprd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-sprd.c b/drivers/i2c/busses/i2c-sprd.c
index 2917fecf6c80..9f77d1ddbaf8 100644
--- a/drivers/i2c/busses/i2c-sprd.c
+++ b/drivers/i2c/busses/i2c-sprd.c
@@ -640,6 +640,7 @@ static const struct of_device_id sprd_i2c_of_match[] = {
 	{ .compatible = "sprd,sc9860-i2c", },
 	{},
 };
+MODULE_DEVICE_TABLE(of, sprd_i2c_of_match);
 
 static struct platform_driver sprd_i2c_driver = {
 	.probe = sprd_i2c_probe,


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] i2c: sprd: Add missing MODULE_DEVICE_TABLE
  2021-04-10  3:50 [PATCH -next] i2c: sprd: Add missing MODULE_DEVICE_TABLE Bixuan Cui
@ 2021-04-12 14:04 ` Baolin Wang
  2021-04-13 12:35 ` Wolfram Sang
  1 sibling, 0 replies; 3+ messages in thread
From: Baolin Wang @ 2021-04-12 14:04 UTC (permalink / raw)
  To: Bixuan Cui
  Cc: Orson Zhai, Chunyan Zhang, Wolfram Sang, Andy Shevchenko,
	Dejin Zheng, Linhua Xu, linux-i2c, kernel-janitors

On Sat, Apr 10, 2021 at 11:51 AM Bixuan Cui <cuibixuan@huawei.com> wrote:
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>

LGTM.
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>

> ---
>  drivers/i2c/busses/i2c-sprd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-sprd.c b/drivers/i2c/busses/i2c-sprd.c
> index 2917fecf6c80..9f77d1ddbaf8 100644
> --- a/drivers/i2c/busses/i2c-sprd.c
> +++ b/drivers/i2c/busses/i2c-sprd.c
> @@ -640,6 +640,7 @@ static const struct of_device_id sprd_i2c_of_match[] = {
>         { .compatible = "sprd,sc9860-i2c", },
>         {},
>  };
> +MODULE_DEVICE_TABLE(of, sprd_i2c_of_match);
>
>  static struct platform_driver sprd_i2c_driver = {
>         .probe = sprd_i2c_probe,
>


-- 
Baolin Wang

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] i2c: sprd: Add missing MODULE_DEVICE_TABLE
  2021-04-10  3:50 [PATCH -next] i2c: sprd: Add missing MODULE_DEVICE_TABLE Bixuan Cui
  2021-04-12 14:04 ` Baolin Wang
@ 2021-04-13 12:35 ` Wolfram Sang
  1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2021-04-13 12:35 UTC (permalink / raw)
  To: Bixuan Cui
  Cc: Orson Zhai, Baolin Wang, Chunyan Zhang, Andy Shevchenko,
	Dejin Zheng, Linhua Xu, linux-i2c, kernel-janitors


[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

On Sat, Apr 10, 2021 at 11:50:44AM +0800, Bixuan Cui wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-10  3:50 [PATCH -next] i2c: sprd: Add missing MODULE_DEVICE_TABLE Bixuan Cui
2021-04-12 14:04 ` Baolin Wang
2021-04-13 12:35 ` Wolfram Sang

Linux-i2c Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-i2c/0 linux-i2c/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-i2c linux-i2c/ https://lore.kernel.org/linux-i2c \
		linux-i2c@vger.kernel.org
	public-inbox-index linux-i2c

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-i2c


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git