From: Wolfram Sang <wsa@kernel.org>
To: Qinglang Miao <miaoqinglang@huawei.com>
Cc: Michal Simek <michal.simek@xilinx.com>,
Dong Aisheng <aisheng.dong@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Oleksij Rempel <linux@rempel-privat.de>,
Vignesh R <vigneshr@ti.com>, Aaro Koskinen <aaro.koskinen@iki.fi>,
Tony Lindgren <tony@atomide.com>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang7@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Pierre-Yves MORDRET <pierre-yves.mordret@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] i2c: fix reference leak when pm_runtime_get_sync fails
Date: Wed, 14 Apr 2021 09:51:27 +0200 [thread overview]
Message-ID: <20210414075127.GA2180@ninjato> (raw)
In-Reply-To: <20201201092924.112461-1-miaoqinglang@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]
On Tue, Dec 01, 2020 at 05:29:24PM +0800, Qinglang Miao wrote:
> pm_runtime_get_sync will increment the PM reference count
> even failed. Forgetting to putting operation will result
> in a reference leak here.
>
> Replace it with pm_runtime_resume_and_get to keep usage
> counter balanced.
>
> BTW, pm_runtime_resume_and_get is introduced in v5.10-rc5 as
> dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get
> to dealwith usage counter")
>
> Qinglang Miao (8):
> i2c: cadence: fix reference leak when pm_runtime_get_sync fails
> i2c: img-scb: fix reference leak when pm_runtime_get_sync fails
> i2c: imx-lpi2c: fix reference leak when pm_runtime_get_sync fails
> i2c: imx: fix reference leak when pm_runtime_get_sync fails
> i2c: omap: fix reference leak when pm_runtime_get_sync fails
> i2c: sprd: fix reference leak when pm_runtime_get_sync fails
> i2c: stm32f7: fix reference leak when pm_runtime_get_sync fails
> i2c: xiic: fix reference leak when pm_runtime_get_sync fails
I applied this series now to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-04-14 7:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 9:29 [PATCH 0/8] i2c: fix reference leak when pm_runtime_get_sync fails Qinglang Miao
2020-12-01 9:31 ` [PATCH 1/8] i2c: cadence: " Qinglang Miao
2020-12-01 9:31 ` [PATCH 2/8] i2c: img-scb: " Qinglang Miao
2020-12-01 9:31 ` [PATCH 3/8] i2c: imx-lpi2c: " Qinglang Miao
2020-12-01 9:31 ` [PATCH 4/8] i2c: imx: " Qinglang Miao
2020-12-11 11:18 ` Oleksij Rempel
2020-12-01 9:31 ` [PATCH 5/8] i2c: omap: " Qinglang Miao
2020-12-01 16:53 ` Grygorii Strashko
2020-12-02 5:13 ` Vignesh Raghavendra
2020-12-01 9:31 ` [PATCH 6/8] i2c: sprd: " Qinglang Miao
2020-12-01 9:31 ` [PATCH 7/8] i2c: stm32f7: " Qinglang Miao
2020-12-01 9:31 ` [PATCH 8/8] i2c: xiic: " Qinglang Miao
2021-04-14 7:51 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210414075127.GA2180@ninjato \
--to=wsa@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=aisheng.dong@nxp.com \
--cc=alexandre.torgue@st.com \
--cc=baolin.wang7@gmail.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=miaoqinglang@huawei.com \
--cc=michal.simek@xilinx.com \
--cc=orsonzhai@gmail.com \
--cc=pierre-yves.mordret@st.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).