linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: Li Huafei <lihuafei1@huawei.com>
Cc: orsonzhai@gmail.com, zhang.lyra@gmail.com, zhengdejin5@gmail.com,
	linhua.xu@unisoc.com, andriy.shevchenko@linux.intel.com,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	yangjihong1@huawei.com, zhangjinhao2@huawei.com
Subject: Re: [PATCH -next] i2c: sprd: Fix PM reference leak in sprd_i2c_master_xfer()
Date: Wed, 14 Apr 2021 10:01:02 +0200	[thread overview]
Message-ID: <20210414080038.GG2180@ninjato> (raw)
In-Reply-To: <20210408125915.137089-1-lihuafei1@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

On Thu, Apr 08, 2021 at 08:59:15PM +0800, Li Huafei wrote:
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here. Fix
> it by replacing it with pm_runtime_resume_and_get to keep usage counter
> balanced.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Li Huafei <lihuafei1@huawei.com>

Thanks, yet I applied this series now:

http://patchwork.ozlabs.org/project/linux-i2c/list/?series=217733&state=*


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2021-04-14  8:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 12:59 [PATCH -next] i2c: sprd: Fix PM reference leak in sprd_i2c_master_xfer() Li Huafei
2021-04-14  8:01 ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210414080038.GG2180@ninjato \
    --to=wsa@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=lihuafei1@huawei.com \
    --cc=linhua.xu@unisoc.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=orsonzhai@gmail.com \
    --cc=yangjihong1@huawei.com \
    --cc=zhang.lyra@gmail.com \
    --cc=zhangjinhao2@huawei.com \
    --cc=zhengdejin5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).