* [PATCH -next] i2c: sprd: Fix PM reference leak in sprd_i2c_master_xfer()
@ 2021-04-08 12:59 Li Huafei
2021-04-14 8:01 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Li Huafei @ 2021-04-08 12:59 UTC (permalink / raw)
To: orsonzhai, zhang.lyra, wsa, zhengdejin5, linhua.xu, andriy.shevchenko
Cc: linux-i2c, linux-kernel, yangjihong1, zhangjinhao2, --lihuafei1
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here. Fix
it by replacing it with pm_runtime_resume_and_get to keep usage counter
balanced.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Li Huafei <lihuafei1@huawei.com>
---
drivers/i2c/busses/i2c-sprd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-sprd.c b/drivers/i2c/busses/i2c-sprd.c
index 2917fecf6c80..8ead7e021008 100644
--- a/drivers/i2c/busses/i2c-sprd.c
+++ b/drivers/i2c/busses/i2c-sprd.c
@@ -290,7 +290,7 @@ static int sprd_i2c_master_xfer(struct i2c_adapter *i2c_adap,
struct sprd_i2c *i2c_dev = i2c_adap->algo_data;
int im, ret;
- ret = pm_runtime_get_sync(i2c_dev->dev);
+ ret = pm_runtime_resume_and_get(i2c_dev->dev);
if (ret < 0)
return ret;
@@ -576,7 +576,7 @@ static int sprd_i2c_remove(struct platform_device *pdev)
struct sprd_i2c *i2c_dev = platform_get_drvdata(pdev);
int ret;
- ret = pm_runtime_get_sync(i2c_dev->dev);
+ ret = pm_runtime_resume_and_get(i2c_dev->dev);
if (ret < 0)
return ret;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] i2c: sprd: Fix PM reference leak in sprd_i2c_master_xfer()
2021-04-08 12:59 [PATCH -next] i2c: sprd: Fix PM reference leak in sprd_i2c_master_xfer() Li Huafei
@ 2021-04-14 8:01 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2021-04-14 8:01 UTC (permalink / raw)
To: Li Huafei
Cc: orsonzhai, zhang.lyra, zhengdejin5, linhua.xu, andriy.shevchenko,
linux-i2c, linux-kernel, yangjihong1, zhangjinhao2
[-- Attachment #1: Type: text/plain, Size: 517 bytes --]
On Thu, Apr 08, 2021 at 08:59:15PM +0800, Li Huafei wrote:
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here. Fix
> it by replacing it with pm_runtime_resume_and_get to keep usage counter
> balanced.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Li Huafei <lihuafei1@huawei.com>
Thanks, yet I applied this series now:
http://patchwork.ozlabs.org/project/linux-i2c/list/?series=217733&state=*
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-14 8:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 12:59 [PATCH -next] i2c: sprd: Fix PM reference leak in sprd_i2c_master_xfer() Li Huafei
2021-04-14 8:01 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).