From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7605DC433ED for ; Thu, 15 Apr 2021 08:18:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5328A6137D for ; Thu, 15 Apr 2021 08:18:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231388AbhDOISy (ORCPT ); Thu, 15 Apr 2021 04:18:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:58060 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231487AbhDOISx (ORCPT ); Thu, 15 Apr 2021 04:18:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 57F7061166; Thu, 15 Apr 2021 08:18:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618474711; bh=04tCYplq8b33RaCbWK7SxxaEvXNco0UanmD8GY9YAzQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aM4dAQzuCtw8Yu3wMD4DFcQQXBigLmdj6pjclWlnPFu1iqvkh6MnrrJxX0n69bRgu Y1G/aADxsBwjl+s9+CnAhstJ280gQ+kQM4lCmyJnxJ8E2KnRAaZGl+RtMNbVXBR4ar 3l0nOAFcrnZwKa0BdBst2jB+U3t5OO9e2/O3Igoji6NTBRRalPZ4mB0qZbpJU85PA0 6+a0XOgqV53gwmBrIAy5CZ3qdGCrPiFgzpDXnqdi0g3k8Fq6BWkDtg9x7ArvuRWK6I GIzIlnwyUYa5Y/f3SjPWS3KxwpcbKSHRrEbMO1UZ2yI/l/sBdU541mGbgEhi/SwN4/ xov4rC7VTq8Gg== Date: Thu, 15 Apr 2021 10:18:28 +0200 From: Wolfram Sang To: Jie Deng Cc: Viresh Kumar , Arnd Bergmann , Linux I2C , virtualization@lists.linux-foundation.org, Linux Kernel Mailing List , "Michael S. Tsirkin" , Jason Wang , Andy Shevchenko , conghui.chen@intel.com, kblaiech@mellanox.com, jarkko.nikula@linux.intel.com, Sergey Semin , Mike Rapoport , loic.poulain@linaro.org, Tali Perry , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Bjorn Andersson , yu1.wang@intel.com, shuo.a.liu@intel.com, Stefan Hajnoczi , Paolo Bonzini Subject: Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver Message-ID: <20210415081828.GD1006@kunai> Mail-Followup-To: Wolfram Sang , Jie Deng , Viresh Kumar , Arnd Bergmann , Linux I2C , virtualization@lists.linux-foundation.org, Linux Kernel Mailing List , "Michael S. Tsirkin" , Jason Wang , Andy Shevchenko , conghui.chen@intel.com, kblaiech@mellanox.com, jarkko.nikula@linux.intel.com, Sergey Semin , Mike Rapoport , loic.poulain@linaro.org, Tali Perry , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Bjorn Andersson , yu1.wang@intel.com, shuo.a.liu@intel.com, Stefan Hajnoczi , Paolo Bonzini References: <226a8d5663b7bb6f5d06ede7701eedb18d1bafa1.1616493817.git.jie.deng@intel.com> <20210323072704.rgoelmq62fl2wjjf@vireshk-i7> <20210415064538.a4vf7egk6l3u6zfz@vireshk-i7> <20210415072131.GA1006@kunai> <20210415072431.apntpcwrk5hp6zg4@vireshk-i7> <20210415072823.GB1006@kunai> <6849a8f0-204a-362a-ed97-e910065ab14f@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rqzD5py0kzyFAOWN" Content-Disposition: inline In-Reply-To: <6849a8f0-204a-362a-ed97-e910065ab14f@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org --rqzD5py0kzyFAOWN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 15, 2021 at 04:15:07PM +0800, Jie Deng wrote: > On 2021/4/15 15:28, Wolfram Sang wrote: >=20 > > > Now that we were able to catch you, I will use the opportunity to > > > clarify the doubts I had. > > >=20 > > > - struct mutex lock in struct virtio_i2c, I don't think this is > > > required since the core takes care of locking in absence of this. > > This is likely correct. >=20 > OK. Then I will remove the lock. Let me have a look first, please. > > > - Use of I2C_CLASS_DEPRECATED flag, I don't think it is required for > > > new drivers. > > This is definately correct :) >=20 > Do you mean a new driver doesn't need to set the following ? >=20 > vi->adap.class =3D I2C_CLASS_DEPRECATED; >=20 > Just leave the class to be 0 ? Yes. DEPRECATED is only for drivers which used to have a class and then chose to remove it. --rqzD5py0kzyFAOWN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmB39tQACgkQFA3kzBSg KbatuQ/9FJmqTmycTEQmAH+pHsmaA2xHRB61k+BmT99wuWU47Hvs0jlpHPnfBuF/ gqqhfGaTtYn56sBaEP8JYVh/AXeGqEM7VFF5Q0Ch2iJHahLiqccNm3a2m2SymigU vGOccVk16DI7iUeZrCVVRYz1mlVTIdOND3YxTbOkTDiooLmWo4bNrZKNsA5/3+VC Ebaq0z1kDGgwcyp2Y81u3rNSCS3FfUOA7He645nS9VpHLFv0fiJez0seNQvW5kJd p1hRNrq/6vLocM+6z8mcwCATQiidcLOMVCFD6sujRkSi4TgFjENGyQ/qcNrprOAY sOlYjISby9Pu8ZoC1RN2qAS+E2uDEsQWJuhBllJ0ob+z4Ai7O+6erwbnLCA+vcDs y8hTGF4jCuPxk5nmD7BJ2uhON7+ixOhHcvQWQd0d2efZKqftZ+5FhlY4VvkuPKNB QswCFUyZVKnBSXGCDqMP4sv7e8zYWf28stc+cUS41VSa3NM2BGEqbRPhDJBGfG1g SL+FUj0LA0rJ72R+NrCVRKB2bf0DyL43uH+mA3kW6bRlKvw52JnMq4eaEJL0e4+I S7KAaB+XNxptIf2LBfuAB3YtIvs+wEsdKo1UdW6wa8HIgm4sgWQOrDhA/fSpAZgP DW6yUCoiK8VdrGeW0EAMytxZp69PQmYZpEz+uNPRLsxOs63g7aA= =0mD3 -----END PGP SIGNATURE----- --rqzD5py0kzyFAOWN--