> > - id->irq = platform_get_irq(pdev, 0); > > + ret = platform_get_irq(pdev, 0); > > + if (ret < 0) > > + return ret; > > Should have been *goto* out3. Sorry for my overlook! :-/ Please send an incremental patch. Thanks!