From: Wolfram Sang <wsa@kernel.org>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH drivers/i2c 2/3] i2c: iop3xx: Fix coding style issues
Date: Thu, 15 Apr 2021 22:27:02 +0200 [thread overview]
Message-ID: <20210415202702.GB6471@kunai> (raw)
In-Reply-To: <1617613430-11921-3-git-send-email-tiantao6@hisilicon.com>
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
On Mon, Apr 05, 2021 at 05:03:49PM +0800, Tian Tao wrote:
> Fix 20 checkpatch errors.
>
> Among these errors, 18 of them are incorrect space usage, such as:
>
> ERROR: space prohibited after that open parenthesis '('
> #128: FILE: drivers/i2c/busses/i2c-iop3xx.c:128:
> + if ( !rc ) rc = -I2C_ERR_BERR
>
> The remaining two errors are trailing statements should be on next line,
> such as:
>
> ERROR: trailing statements should be on next line
> #128: FILE: drivers/i2c/busses/i2c-iop3xx.c:128:
> + if ( !rc ) rc = -I2C_ERR_BERR;
>
> No functional changes.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> Signed-off-by: Zihao Tang <tangzihao1@hisilicon.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-04-15 20:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 9:03 [PATCH drivers/i2c 0/3] Fix ERRORs reported by checkpatch Tian Tao
2021-04-05 9:03 ` [PATCH drivers/i2c 1/3] i2c: amd8111: Fix coding style issues Tian Tao
2021-04-13 20:25 ` Wolfram Sang
2021-04-14 1:03 ` tiantao (H)
2021-04-14 8:31 ` Wolfram Sang
2021-04-14 8:40 ` tiantao (H)
2021-04-15 20:26 ` Wolfram Sang
2021-04-05 9:03 ` [PATCH drivers/i2c 2/3] i2c: iop3xx: " Tian Tao
2021-04-15 20:27 ` Wolfram Sang [this message]
2021-04-05 9:03 ` [PATCH drivers/i2c 3/3] i2c: nomadik: Fix space errors Tian Tao
2021-04-15 20:27 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415202702.GB6471@kunai \
--to=wsa@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).