* [PATCH 1/3] i2c: mediatek: Fix send master code at more than 1MHz
2021-04-17 6:46 [PATCH 0/3] Add some fix patches Qii Wang
@ 2021-04-17 6:46 ` Qii Wang
2021-04-17 20:06 ` Wolfram Sang
2021-04-17 6:46 ` [PATCH 2/3] i2c: mediatek: Fix wrong dma sync flag Qii Wang
2021-04-17 6:46 ` [PATCH 3/3] i2c: mediatek: Use scl_int_delay_ns to compensate clock-stretching Qii Wang
2 siblings, 1 reply; 7+ messages in thread
From: Qii Wang @ 2021-04-17 6:46 UTC (permalink / raw)
To: wsa
Cc: matthias.bgg, linux-i2c, linux-arm-kernel, linux-kernel,
linux-mediatek, srv_heupstream, leilk.liu, qii.wang
There are some omissions in the previous patch about replacing
I2C_MAX_FAST_MODE__FREQ with I2C_MAX_FAST_MODE_PLUS_FREQ and
need to fix it.
Fixes: b44658e755b5("i2c: mediatek: Send i2c master code at more than 1MHz")
Signed-off-by: Qii Wang <qii.wang@mediatek.com>
---
drivers/i2c/busses/i2c-mt65xx.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 2ffd2f3..3e34261 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -564,7 +564,7 @@ static const struct i2c_spec_values *mtk_i2c_get_spec(unsigned int speed)
static int mtk_i2c_max_step_cnt(unsigned int target_speed)
{
- if (target_speed > I2C_MAX_FAST_MODE_FREQ)
+ if (target_speed > I2C_MAX_FAST_MODE_PLUS_FREQ)
return MAX_HS_STEP_CNT_DIV;
else
return MAX_STEP_CNT_DIV;
@@ -635,7 +635,7 @@ static int mtk_i2c_check_ac_timing(struct mtk_i2c *i2c,
if (sda_min > sda_max)
return -3;
- if (check_speed > I2C_MAX_FAST_MODE_FREQ) {
+ if (check_speed > I2C_MAX_FAST_MODE_PLUS_FREQ) {
if (i2c->dev_comp->ltiming_adjust) {
i2c->ac_timing.hs = I2C_TIME_DEFAULT_VALUE |
(sample_cnt << 12) | (high_cnt << 8);
@@ -850,7 +850,7 @@ static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, struct i2c_msg *msgs,
control_reg = mtk_i2c_readw(i2c, OFFSET_CONTROL) &
~(I2C_CONTROL_DIR_CHANGE | I2C_CONTROL_RS);
- if ((i2c->speed_hz > I2C_MAX_FAST_MODE_FREQ) || (left_num >= 1))
+ if ((i2c->speed_hz > I2C_MAX_FAST_MODE_PLUS_FREQ) || (left_num >= 1))
control_reg |= I2C_CONTROL_RS;
if (i2c->op == I2C_MASTER_WRRD)
@@ -1067,7 +1067,8 @@ static int mtk_i2c_transfer(struct i2c_adapter *adap,
}
}
- if (i2c->auto_restart && num >= 2 && i2c->speed_hz > I2C_MAX_FAST_MODE_FREQ)
+ if (i2c->auto_restart && num >= 2 &&
+ i2c->speed_hz > I2C_MAX_FAST_MODE_PLUS_FREQ)
/* ignore the first restart irq after the master code,
* otherwise the first transfer will be discarded.
*/
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/3] i2c: mediatek: Fix send master code at more than 1MHz
2021-04-17 6:46 ` [PATCH 1/3] i2c: mediatek: Fix send master code at more than 1MHz Qii Wang
@ 2021-04-17 20:06 ` Wolfram Sang
0 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2021-04-17 20:06 UTC (permalink / raw)
To: Qii Wang
Cc: matthias.bgg, linux-i2c, linux-arm-kernel, linux-kernel,
linux-mediatek, srv_heupstream, leilk.liu
[-- Attachment #1: Type: text/plain, Size: 377 bytes --]
On Sat, Apr 17, 2021 at 02:46:50PM +0800, Qii Wang wrote:
> There are some omissions in the previous patch about replacing
> I2C_MAX_FAST_MODE__FREQ with I2C_MAX_FAST_MODE_PLUS_FREQ and
> need to fix it.
>
> Fixes: b44658e755b5("i2c: mediatek: Send i2c master code at more than 1MHz")
> Signed-off-by: Qii Wang <qii.wang@mediatek.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/3] i2c: mediatek: Fix wrong dma sync flag
2021-04-17 6:46 [PATCH 0/3] Add some fix patches Qii Wang
2021-04-17 6:46 ` [PATCH 1/3] i2c: mediatek: Fix send master code at more than 1MHz Qii Wang
@ 2021-04-17 6:46 ` Qii Wang
2021-04-17 20:07 ` Wolfram Sang
2021-04-17 6:46 ` [PATCH 3/3] i2c: mediatek: Use scl_int_delay_ns to compensate clock-stretching Qii Wang
2 siblings, 1 reply; 7+ messages in thread
From: Qii Wang @ 2021-04-17 6:46 UTC (permalink / raw)
To: wsa
Cc: matthias.bgg, linux-i2c, linux-arm-kernel, linux-kernel,
linux-mediatek, srv_heupstream, leilk.liu, qii.wang
The right flag is apdma_sync when apdma remove hand-shake signel.
Signed-off-by: Qii Wang <qii.wang@mediatek.com>
---
drivers/i2c/busses/i2c-mt65xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 3e34261..bf25acb 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -479,7 +479,7 @@ static void mtk_i2c_init_hw(struct mtk_i2c *i2c)
{
u16 control_reg;
- if (i2c->dev_comp->dma_sync) {
+ if (i2c->dev_comp->apdma_sync) {
writel(I2C_DMA_WARM_RST, i2c->pdmabase + OFFSET_RST);
udelay(10);
writel(I2C_DMA_CLR_FLAG, i2c->pdmabase + OFFSET_RST);
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/3] i2c: mediatek: Fix wrong dma sync flag
2021-04-17 6:46 ` [PATCH 2/3] i2c: mediatek: Fix wrong dma sync flag Qii Wang
@ 2021-04-17 20:07 ` Wolfram Sang
0 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2021-04-17 20:07 UTC (permalink / raw)
To: Qii Wang
Cc: matthias.bgg, linux-i2c, linux-arm-kernel, linux-kernel,
linux-mediatek, srv_heupstream, leilk.liu
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
On Sat, Apr 17, 2021 at 02:46:51PM +0800, Qii Wang wrote:
> The right flag is apdma_sync when apdma remove hand-shake signel.
>
> Signed-off-by: Qii Wang <qii.wang@mediatek.com>
Added:
Fixes: 05f6f7271a38 ("i2c: mediatek: Fix apdma and i2c hand-shake timeout")
and applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 3/3] i2c: mediatek: Use scl_int_delay_ns to compensate clock-stretching
2021-04-17 6:46 [PATCH 0/3] Add some fix patches Qii Wang
2021-04-17 6:46 ` [PATCH 1/3] i2c: mediatek: Fix send master code at more than 1MHz Qii Wang
2021-04-17 6:46 ` [PATCH 2/3] i2c: mediatek: Fix wrong dma sync flag Qii Wang
@ 2021-04-17 6:46 ` Qii Wang
2021-04-17 20:09 ` Wolfram Sang
2 siblings, 1 reply; 7+ messages in thread
From: Qii Wang @ 2021-04-17 6:46 UTC (permalink / raw)
To: wsa
Cc: matthias.bgg, linux-i2c, linux-arm-kernel, linux-kernel,
linux-mediatek, srv_heupstream, leilk.liu, qii.wang
The parameters of tSU,STA/tHD,STA/tSU,STOP maybe out of spec due
to device clock-stretch or circuit loss, we could get a suitable
scl_int_delay_ns from i2c_timings to compensate these parameters
to meet the spec via EXT_CONF register.
Signed-off-by: Qii Wang <qii.wang@mediatek.com>
---
drivers/i2c/busses/i2c-mt65xx.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index bf25acb..5ddfa4e 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -231,6 +231,7 @@ struct mtk_i2c {
struct i2c_adapter adap; /* i2c host adapter */
struct device *dev;
struct completion msg_complete;
+ struct i2c_timings timing_info;
/* set in i2c probe */
void __iomem *base; /* i2c base addr */
@@ -607,7 +608,8 @@ static int mtk_i2c_check_ac_timing(struct mtk_i2c *i2c,
else
clk_ns = sample_ns / 2;
- su_sta_cnt = DIV_ROUND_UP(spec->min_su_sta_ns, clk_ns);
+ su_sta_cnt = DIV_ROUND_UP(spec->min_su_sta_ns +
+ i2c->timing_info.scl_int_delay_ns, clk_ns);
if (su_sta_cnt > max_sta_cnt)
return -1;
@@ -1176,6 +1178,8 @@ static int mtk_i2c_parse_dt(struct device_node *np, struct mtk_i2c *i2c)
i2c->use_push_pull =
of_property_read_bool(np, "mediatek,use-push-pull");
+ i2c_parse_fw_timings(i2c->dev, &i2c->timing_info, true);
+
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 3/3] i2c: mediatek: Use scl_int_delay_ns to compensate clock-stretching
2021-04-17 6:46 ` [PATCH 3/3] i2c: mediatek: Use scl_int_delay_ns to compensate clock-stretching Qii Wang
@ 2021-04-17 20:09 ` Wolfram Sang
0 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2021-04-17 20:09 UTC (permalink / raw)
To: Qii Wang
Cc: matthias.bgg, linux-i2c, linux-arm-kernel, linux-kernel,
linux-mediatek, srv_heupstream, leilk.liu
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
On Sat, Apr 17, 2021 at 02:46:52PM +0800, Qii Wang wrote:
> The parameters of tSU,STA/tHD,STA/tSU,STOP maybe out of spec due
> to device clock-stretch or circuit loss, we could get a suitable
> scl_int_delay_ns from i2c_timings to compensate these parameters
> to meet the spec via EXT_CONF register.
>
> Signed-off-by: Qii Wang <qii.wang@mediatek.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread