From: Rob Herring <robh@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Chris Brandt <chris.brandt@renesas.com>,
devicetree@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH/RFC 4/6] dt-bindings: i2c: renesas,iic: Convert to json-schema
Date: Thu, 6 May 2021 15:54:32 -0500 [thread overview]
Message-ID: <20210506205432.GA782463@robh.at.kernel.org> (raw)
In-Reply-To: <ecfaf6be5e8c285db2bcc823bb1dd89931fa5c29.1620138454.git.geert+renesas@glider.be>
On Tue, May 04, 2021 at 04:51:11PM +0200, Geert Uytterhoeven wrote:
> Convert the Renesas R-Mobile I2C Bus Interface (IIC) Device Tree binding
> documentation to json-schema.
>
> Document missing properties.
> R-Mobile A1 and SH-Mobile have multiple interrupts.
> Update the example to match reality.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> It is still not clear to me which instances on R-Car Gen2 and RZ/G1
> support automatic transmission, cfr. this note for the IIC3 instance in
> the Hardware User's Manual:
>
> Automatic transmission for PMIC control (DVFS) is not available
> because the second generation R-Car series and RZ/G series products
> do not support the DVFS function (automatic transmission can be used
> as a hardware function, but this is not meaningful for actual use
> cases).
>
> The only thing that's clear is that R-Car E2 and RZ/G1E do not have the
> automatic transmission registers. Note that current r8a7745.dtsi and
> r8a7794.dtsi do not reflect that.
>
> This binding interpretes the note as that IIC3 does not support
> automatic transmission on R-Car H2, M2-W, M2-N, and V2H, and RZ/G1H,
> RZ/H1M, RZ/G1N, while the other (if any) IIC instances on these SoCs do
> support automatic transmission. This matches with the current
> r8a774[234].dtsi, which do not declare compatibility with the
> family-specific and generic versions. Note that the current
> r8a779[0123].dtsi still do, and thus should be updated!
>
> Possible alternative interpretations of the note are:
> - Only IIC3 has the automatic transmission registers. But the
> automatic transmission feature is not useful as the SoCs lack DVFS
> support.
> - All IIC instances have the automatic transmission registers, and
> IIC3 is traditionally used to control the PMIC. But as the SoCs
> lack DVFS support, the automatic transmission feature is not useful.
> As R-Car V2H has only instance IIC3, and is documented to have
> automatic transmissiong registers, this might be the correct
> interpration?
> - Anything else?
Can't help there, but looks fine otherwise.
Reviewed-by: Rob Herring <robh@kernel.org>
>
> Thanks for your comments!
> ---
> .../devicetree/bindings/i2c/renesas,iic.txt | 72 --------
> .../bindings/i2c/renesas,rmobile-iic.yaml | 160 ++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 161 insertions(+), 73 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/i2c/renesas,iic.txt
> create mode 100644 Documentation/devicetree/bindings/i2c/renesas,rmobile-iic.yaml
next prev parent reply other threads:[~2021-05-06 20:54 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 14:35 [PATCH 0/6] dt-bindings: i2c: renesas: Convert to json-schema Geert Uytterhoeven
2021-05-04 14:35 ` [PATCH 1/6] i2c: rcar: Drop "renesas,i2c-rcar" Geert Uytterhoeven
2021-05-04 14:51 ` Geert Uytterhoeven
2021-05-05 7:18 ` Wolfram Sang
2021-05-28 7:55 ` Wolfram Sang
2021-05-04 14:35 ` [PATCH 2/6] dt-bindings: i2c: renesas,i2c: " Geert Uytterhoeven
2021-05-04 14:51 ` Geert Uytterhoeven
2021-05-05 7:18 ` Wolfram Sang
2021-05-06 20:50 ` Rob Herring
2021-05-28 7:56 ` Wolfram Sang
2021-05-04 14:35 ` [PATCH 3/6] dt-bindings: i2c: renesas,i2c: Convert to json-schema Geert Uytterhoeven
2021-05-04 14:51 ` Geert Uytterhoeven
2021-05-06 20:52 ` Rob Herring
2021-05-28 7:56 ` Wolfram Sang
2021-05-04 14:35 ` [PATCH/RFC 4/6] dt-bindings: i2c: renesas,iic: " Geert Uytterhoeven
2021-05-04 14:51 ` Geert Uytterhoeven
2021-05-05 7:33 ` Wolfram Sang
2021-05-26 14:47 ` Geert Uytterhoeven
2021-05-28 13:51 ` Wolfram Sang
2021-05-28 14:14 ` Geert Uytterhoeven
2021-05-06 20:54 ` Rob Herring [this message]
2021-05-04 14:35 ` [PATCH 5/6] dt-bindings: i2c: renesas,riic: " Geert Uytterhoeven
2021-05-04 14:51 ` Geert Uytterhoeven
2021-05-06 20:56 ` Rob Herring
2021-05-07 6:56 ` Geert Uytterhoeven
2021-05-28 7:56 ` Wolfram Sang
2021-05-04 14:35 ` [PATCH 6/6] dt-bindings: i2c: renesas,iic-emev2: " Geert Uytterhoeven
2021-05-04 14:51 ` Geert Uytterhoeven
2021-05-06 20:57 ` Rob Herring
2021-05-28 7:56 ` Wolfram Sang
2021-05-04 14:42 ` [PATCH 0/6] dt-bindings: i2c: renesas: " Rob Herring
2021-05-04 14:51 ` Geert Uytterhoeven
2021-05-04 14:51 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506205432.GA782463@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=chris.brandt@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).