From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88A15C47083 for ; Thu, 3 Jun 2021 01:46:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D020613BF for ; Thu, 3 Jun 2021 01:46:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229617AbhFCBsU (ORCPT ); Wed, 2 Jun 2021 21:48:20 -0400 Received: from twspam01.aspeedtech.com ([211.20.114.71]:22310 "EHLO twspam01.aspeedtech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229567AbhFCBsU (ORCPT ); Wed, 2 Jun 2021 21:48:20 -0400 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1531X0kq099798; Thu, 3 Jun 2021 09:33:00 +0800 (GMT-8) (envelope-from jamin_lin@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 3 Jun 2021 09:46:28 +0800 Date: Thu, 3 Jun 2021 09:46:26 +0800 From: Jamin Lin To: Rob Herring CC: Joel Stanley , Andrew Jeffery , "Brendan Higgins" , Benjamin Herrenschmidt , Rayn Chen , "open list:I2C SUBSYSTEM HOST DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , "moderated list:ARM/ASPEED I2C DRIVER" , Ryan Chen , "Chin-Ting Kuo" , Troy Lee , Steven Lee Subject: Re: [PATCH v2 1/1] dt-bindings: aspeed-i2c: Convert txt to yaml format Message-ID: <20210603014625.GA1759@aspeedtech.com> References: <20210527102512.20684-1-jamin_lin@aspeedtech.com> <20210527102512.20684-2-jamin_lin@aspeedtech.com> <20210602201720.GA3910963@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20210602201720.GA3910963@robh.at.kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1531X0kq099798 Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org The 06/02/2021 20:17, Rob Herring wrote: > On Thu, May 27, 2021 at 06:25:05PM +0800, Jamin Lin wrote: > > Convert aspeed i2c to yaml. > > > > Signed-off-by: Jamin Lin > > --- > > .../devicetree/bindings/i2c/aspeed,i2c.yaml | 86 +++++++++++++++++++ > > .../devicetree/bindings/i2c/i2c-aspeed.txt | 49 ----------- > > 2 files changed, 86 insertions(+), 49 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-aspeed.txt > > > > diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > new file mode 100644 > > index 000000000000..1f7064d77708 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > @@ -0,0 +1,86 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/i2c/aspeed,i2c.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ASPEED I2C on the AST24XX, AST25XX, and AST26XX SoCs Device Tree Bindings > > + > > +maintainers: > > + - Rayn Chen > > + > > +allOf: > > + - $ref: /schemas/i2c/i2c-controller.yaml# > > + > > +properties: > > + compatible: > > + enum: > > + - aspeed,ast2400-i2c-bus > > + - aspeed,ast2500-i2c-bus > > + - aspeed,ast2600-i2c-bus > > + > > + "#size-cells": > > + const: 0 > > + > > + "#address-cells": > > + const: 1 > > These 2 are covered by i2c-controller.yaml. > Will remove them. > > + > > + reg: > > + minItems: 1 > > + maxItems: 2 > > + items: > > + - description: address offset and range of bus > > + - description: address offset and range of bus buffer > > + > > + interrupts: > > + maxItems: 1 > > + description: interrupt number > > Drop. Not a useful description. > Will remove it. > > + > > + clocks: > > + maxItems: 1 > > + description: > > + root clock of bus, should reference the APB > > + clock in the second cell > > + > > + reset: > > resets > Thanks to find the typo. > > + maxItems: 1 > > + description: phandle to reset controller with the reset number in > > + the second cell > > No need to describe the format of 'resets'. > > > + > > + bus-frequency: > > + minimum: 500 > > + maximum: 4000000 > > + default: 100000 > > + description: frequency of the bus clock in Hz defaults to 100 kHz when not > > + specified > > + > > + multi-master: > > + type: boolean > > + description: > > + states that there is another master active on this bus > > + > > +required: > > + - reg > > + - compatible > > + - clocks > > + - resets > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + #include > > + i2c0: i2c-bus@40 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + #interrupt-cells = <1>; > > + reg = <0x40 0x40>; > > + compatible = "aspeed,ast2500-i2c-bus"; > > Convention is compatible first in the list of properties. > Will move compatible first in the list of properties. > > + clocks = <&syscon ASPEED_CLK_APB>; > > + resets = <&syscon ASPEED_RESET_I2C>; > > + bus-frequency = <100000>; > > + interrupts = <0>; > > + interrupt-parent = <&i2c_ic>; > > + status = "disabled"; > > Don't show status in examples especially when disabling disables some > validation... > Will remove it. > > + /* Does not need pinctrl properties */ > > + }; Thanks for your suggestion. I will send v3 patch.