From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC0A3C11F65 for ; Wed, 30 Jun 2021 15:09:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 989D661476 for ; Wed, 30 Jun 2021 15:09:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235488AbhF3PLj (ORCPT ); Wed, 30 Jun 2021 11:11:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235466AbhF3PLi (ORCPT ); Wed, 30 Jun 2021 11:11:38 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C00C2C061787 for ; Wed, 30 Jun 2021 08:09:09 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id g24-20020a17090ace98b029017225d0c013so3228541pju.1 for ; Wed, 30 Jun 2021 08:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Qwm5a7S4d67APmjTQTuY/hq2xmS0TKPAGGqg/CRnPBo=; b=hQH2rW5/+D+sJ/vCi4D9X8JFCi1w+1YhK43zeTPcZwmHjtigMz7Hxi58hLvpUD+8hL SVROijWxos23t5Bb/r1YMi/mc8Qlw+LBTwkIUiGnwDG98PM+UoaKA+VhNbnNXA8clSry 3ldvy7ODk38s0v9vbtVMyVEej8y/uv7Aw61OwDGVw//0fds4QMMRcHpqOZY8wLcHVsR2 HE0T2XuJbZ9NOqgWdU6Qigdb4P/k4fjulqOovDJrE67zg57LT9uKxhlcwispghfWLBia hEQgsgBUr6LNJfYAlwn0AIuac1fIrsccm82oCVHZqn4WRMRnsiJDSZ2tL/2WGTWXXZQR DPFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Qwm5a7S4d67APmjTQTuY/hq2xmS0TKPAGGqg/CRnPBo=; b=Dt/YJQ0pX8oAQPFj9oDvfNS2Lpic/mFlX3vPVGnGWdS6Wj3FZcTTM27L5l+fHiZCGu Im+ehhhom68qhsto12yBsoM89MQMWv4B8+tqDJAvwp9mntgjB+ijfuVKaP/w5GdTvUQy WOWn4yOu55LNpfXu93mEU+pXrK6OVXY7OpVoT4KtUqk83SCHe0qGOCRR1Sy7qvHc3ZIv lWuRV8qt/xQPryIoQq1tx/6dqAfBKjPzyUOpPAIA1Zo5MMotCVCoJU2117NQ68FCCuVK xihNt5t1wrnWfso8fEV0mrDWdFaeaKr+GjDa84hMsqW9qnLhtmh4HerCeyrd0o78TBBH uVNA== X-Gm-Message-State: AOAM530OA8sIG0SUo1Tch1nfFrh59NeAhMQ7YpWpn6I2Hpv/2yl/8LBw J7zFCHv10uC/AA89gMOWl9XVvQ== X-Google-Smtp-Source: ABdhPJym5Xp6zNUdD2feUDXohHd8CRMVwRm3dGknfSKatUpwmL5kTwmKxG7StUS5g65JI3R/thswEg== X-Received: by 2002:a17:90b:4f83:: with SMTP id qe3mr5005813pjb.49.1625065749166; Wed, 30 Jun 2021 08:09:09 -0700 (PDT) Received: from localhost ([106.201.108.2]) by smtp.gmail.com with ESMTPSA id f69sm3163333pfa.24.2021.06.30.08.09.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Jun 2021 08:09:08 -0700 (PDT) Date: Wed, 30 Jun 2021 20:39:01 +0530 From: Viresh Kumar To: Wolfram Sang , Arnd Bergmann , Jie Deng , Linux I2C , virtualization@lists.linux-foundation.org, Linux Kernel Mailing List , "Michael S. Tsirkin" , Jason Wang , Andy Shevchenko , conghui.chen@intel.com, kblaiech@mellanox.com, jarkko.nikula@linux.intel.com, Sergey Semin , Mike Rapoport , loic.poulain@linaro.org, Tali Perry , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Bjorn Andersson , yu1.wang@intel.com, shuo.a.liu@intel.com, Stefan Hajnoczi , Paolo Bonzini Subject: Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver Message-ID: <20210630150901.5uzjelg4k7xgbumb@vireshk-i7> References: <226a8d5663b7bb6f5d06ede7701eedb18d1bafa1.1616493817.git.jie.deng@intel.com> <20210629041017.dsvzldikvsaade37@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On 30-06-21, 16:38, Wolfram Sang wrote: > > While we are at it, this has been replaced by a Rust counterpart [1] > > (as that makes it hypervisor agnostic, which is the goal of my work > > here) and I need someone with I2C knowledge to help review it. It > > should be okay even if you don't understand Rust a lot, just review > > this file[2] which is where most of i2c specific stuff lies. > > From the high level review I can provide, it looks good to me. Block > transfers are missing, but I think you said that already. Mising Rust > experience, I might miss details, of course. But the general approach > seems fine to me. smbus_prepare() will get a bit more messy when you add > block transfers, but it still looks bearable, I think. Thanks for having a look. -- viresh