Re: [PATCH 04/10] i2c: i801: Remove not needed debug message

[Jean Delvare <jdelvare@suse.de>]

On Sun, 01 Aug 2021 16:19:24 +0200, Heiner Kallweit wrote:
> If a user is interested in such details he can enable smbus tracing.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>  drivers/i2c/busses/i2c-i801.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index 504f02e1e..d971ee20c 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -558,10 +558,6 @@ static void i801_isr_byte_done(struct i801_priv *priv)
>  					priv->len);
>  				/* FIXME: Recover */
>  				priv->len = I2C_SMBUS_BLOCK_MAX;
> -			} else {
> -				dev_dbg(&priv->pci_dev->dev,
> -					"SMBus block read size is %d\n",
> -					priv->len);
>  			}
>  			priv->data[-1] = priv->len;
>  		}

I think this is a leftover from the development phase, when we were just
adding support for this feature and needed to verify that the interrupt
callback was being called when and only when needed. I agree it no
longer has any value and can be removed now.

Reviewed-by: Jean Delvare <jdelvare@suse.de>
Tested-by: Jean Delvare <jdelvare@suse.de>

-- 
Jean Delvare
SUSE L3 Support