* [PATCH] i2c: pxa: drop unneeded MODULE_ALIAS
@ 2021-09-16 17:05 Krzysztof Kozlowski
2021-10-02 7:31 ` Wolfram Sang
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-09-16 17:05 UTC (permalink / raw)
To: linux-kernel; +Cc: Krzysztof Kozlowski, linux-i2c
The MODULE_DEVICE_TABLE already creates proper alias for platform
driver. Having another MODULE_ALIAS causes the alias to be duplicated.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
drivers/i2c/busses/i2c-pxa.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index a636ea0eb50a..690188a9ffff 100644
--- a/drivers/i2c/busses/i2c-pxa.c
+++ b/drivers/i2c/busses/i2c-pxa.c
@@ -1547,7 +1547,6 @@ static void __exit i2c_adap_pxa_exit(void)
}
MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:pxa2xx-i2c");
subsys_initcall(i2c_adap_pxa_init);
module_exit(i2c_adap_pxa_exit);
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: pxa: drop unneeded MODULE_ALIAS
2021-09-16 17:05 [PATCH] i2c: pxa: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
@ 2021-10-02 7:31 ` Wolfram Sang
2021-10-04 6:18 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2021-10-02 7:31 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: linux-kernel, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
On Thu, Sep 16, 2021 at 07:05:17PM +0200, Krzysztof Kozlowski wrote:
> The MODULE_DEVICE_TABLE already creates proper alias for platform
> driver. Having another MODULE_ALIAS causes the alias to be duplicated.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Applied to for-next, thanks!
Good catch. Do you want to fix all of these duplicates in the tree? I
found two handful of the same pattern and could assist you in removing
themt. But I also don't want to steal your credits. Let me know if I can
help.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: pxa: drop unneeded MODULE_ALIAS
2021-10-02 7:31 ` Wolfram Sang
@ 2021-10-04 6:18 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-10-04 6:18 UTC (permalink / raw)
To: Wolfram Sang, linux-kernel, linux-i2c
On 02/10/2021 09:31, Wolfram Sang wrote:
> On Thu, Sep 16, 2021 at 07:05:17PM +0200, Krzysztof Kozlowski wrote:
>> The MODULE_DEVICE_TABLE already creates proper alias for platform
>> driver. Having another MODULE_ALIAS causes the alias to be duplicated.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> Applied to for-next, thanks!
>
> Good catch. Do you want to fix all of these duplicates in the tree? I
> found two handful of the same pattern and could assist you in removing
> themt. But I also don't want to steal your credits. Let me know if I can
> help.
>
I think I fixed all of platform aliases. I also removed duplicates for
few USB and ACPI (some others seems to be not an actual duplicate or
intentional).
All patches:
https://lore.kernel.org/lkml/?q=f%3Akozlowski+MODULE_ALIAS
If you see something not fixed, go ahead.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-04 6:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 17:05 [PATCH] i2c: pxa: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
2021-10-02 7:31 ` Wolfram Sang
2021-10-04 6:18 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).