From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F72FC47091 for ; Sun, 30 May 2021 16:01:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D96E2611BD for ; Sun, 30 May 2021 16:01:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229683AbhE3QC7 (ORCPT ); Sun, 30 May 2021 12:02:59 -0400 Received: from mxout02.lancloud.ru ([45.84.86.82]:36458 "EHLO mxout02.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229599AbhE3QC6 (ORCPT ); Sun, 30 May 2021 12:02:58 -0400 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout02.lancloud.ru 197AA2326C85 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH0/2] Fix deferred probing in the I2C bus drivers From: Sergey Shtylyov To: Sergey Shtylyov , , Ard Biesheuvel References: Organization: Open Mobile Platform Message-ID: <3985ef30-dc42-a6c3-6d69-2347837cd34a@omp.ru> Date: Sun, 30 May 2021 19:01:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1908.lancloud.ru (fd00:f066::208) Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On 5/30/21 6:53 PM, Sergey Shtylyov wrote: [...] >>> Here are 2 patches against the 'i2c/for-current' branch of Wolfram's 'linux.git' repo. >>> The affected drivers call platform_get_irq() but override its result in case of error >>> which prevents the deferred probing from working. >>> >>> [1/2] i2c: iop3xx: fix deferred probing >>> [2/2] i2c: synquacer: fix deferred probing >> >> Please hold on with this series; I'm gonna add another patch... > > Actually, I'm unsure about drivers/i2c/busses/i2c-pca-platform.c: normally it > uses polling iff the (considered optional) IRQ can't be set up (irq < 0 returned > from platform_get_irq_optional()) then polling mode is used. I started to be tautologcial, should really re-read the msgs before seding... :-) > I have a patch to > propaate -EPROBE_DEFER upstream but I'm not sure what is better : sefer the probe Propagate, of/c. :-) > (and potentially falling permanently iff the kernel wouldn't able to finally set Wasn't. :-) > up the IRQ or to start the I2C driver in the polling mode right away. Does these > doubts even make sense? :-) MBR, Sergey