From: Dmitry Osipenko <digetx@gmail.com>
To: Sowjanya Komatineni <skomatineni@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
frankc@nvidia.com, hverkuil@xs4all.nl, sakari.ailus@iki.fi,
robh+dt@kernel.org, helen.koike@collabora.com
Cc: sboyd@kernel.org, gregkh@linuxfoundation.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [RFC PATCH v4 12/14] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done
Date: Mon, 27 Jul 2020 03:10:25 +0300 [thread overview]
Message-ID: <4a7444e7-2e64-d96e-d764-b81ee0c82525@gmail.com> (raw)
In-Reply-To: <1595548272-9809-13-git-send-email-skomatineni@nvidia.com>
24.07.2020 02:51, Sowjanya Komatineni пишет:
> With the split of MIPI calibration into tegra_mipi_calibrate() and
> tegra_mipi_wait(), MIPI clock is not kept enabled till the calibration
> is done.
>
> So, this patch skips disabling MIPI clock after triggering start of
> calibration and disables it only after waiting for done status from
> the calibration logic.
>
> This patch renames tegra_mipi_calibrate() as tegra_mipi_start_calibration()
> and tegra_mipi_wait() as tegra_mipi_finish_calibration() to be inline
> with their usage....
> -int tegra_mipi_calibrate(struct tegra_mipi_device *device);
> -int tegra_mipi_wait(struct tegra_mipi_device *device);
> +int tegra_mipi_start_calibrate(struct tegra_mipi_device *device);
> +int tegra_mipi_finish_calibrate(struct tegra_mipi_device *device);
> +void tegra_mipi_cancel_calibrate(struct tegra_mipi_device *device);
Could you please use function names as they are named in the commit's
description? The "start_calibrate" doesn't sound like a proper English,
otherwise patch looks good to me.
next prev parent reply other threads:[~2020-07-27 0:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 23:50 [RFC PATCH v4 00/14] Support for Tegra video capture from external sensor Sowjanya Komatineni
2020-07-23 23:50 ` [RFC PATCH v4 01/14] i2c: tegra: Don't mark VI I2C as IRQ safe runtime PM Sowjanya Komatineni
2020-07-26 23:30 ` Dmitry Osipenko
2020-07-23 23:51 ` [RFC PATCH v4 02/14] i2c: tegra: Remove NULL pointer check before clk_enable/disable/prepare/unprepare Sowjanya Komatineni
2020-07-23 23:51 ` [RFC PATCH v4 03/14] i2c: tegra: Fix the error path in tegra_i2c_runtime_resume Sowjanya Komatineni
2020-07-26 23:41 ` Dmitry Osipenko
2020-07-23 23:51 ` [RFC PATCH v4 04/14] i2c: tegra: Fix runtime resume to re-init VI I2C Sowjanya Komatineni
2020-07-26 23:53 ` Dmitry Osipenko
2020-07-27 20:58 ` Sowjanya Komatineni
2020-07-23 23:51 ` [RFC PATCH v4 05/14] i2c: tegra: Avoid tegra_i2c_init_dma() for Tegra210 vi i2c Sowjanya Komatineni
2020-07-26 23:57 ` Dmitry Osipenko
2020-07-23 23:51 ` [RFC PATCH v4 06/14] media: tegra-video: Fix channel format alignment Sowjanya Komatineni
2020-07-23 23:51 ` [RFC PATCH v4 07/14] media: tegra-video: Enable TPG based on kernel config Sowjanya Komatineni
2020-07-23 23:51 ` [RFC PATCH v4 08/14] media: tegra-video: Update format lookup to offset based Sowjanya Komatineni
2020-07-23 23:51 ` [RFC PATCH v4 09/14] dt-bindings: tegra: Update VI and CSI bindings with port info Sowjanya Komatineni
2020-07-23 23:51 ` [RFC PATCH v4 10/14] media: tegra-video: Add support for external sensor capture Sowjanya Komatineni
2020-07-23 23:51 ` [RFC PATCH v4 11/14] media: tegra-video: Add support for selection ioctl ops Sowjanya Komatineni
2020-07-23 23:51 ` [RFC PATCH v4 12/14] gpu: host1x: mipi: Keep MIPI clock enabled till calibration is done Sowjanya Komatineni
2020-07-27 0:10 ` Dmitry Osipenko [this message]
2020-07-23 23:51 ` [RFC PATCH v4 13/14] media: tegra-video: Add CSI MIPI pads calibration Sowjanya Komatineni
2020-07-23 23:51 ` [RFC PATCH v4 14/14] media: tegra-video: Compute settle times based on the clock rate Sowjanya Komatineni
2020-07-24 9:43 ` [RFC PATCH v4 00/14] Support for Tegra video capture from external sensor Hans Verkuil
2020-07-24 19:16 ` Wolfram Sang
2020-07-27 0:25 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a7444e7-2e64-d96e-d764-b81ee0c82525@gmail.com \
--to=digetx@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frankc@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sboyd@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).