linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <Michael.Wu@vatics.com>
To: <andriy.shevchenko@linux.intel.com>, <lkp@intel.com>
Cc: <jarkko.nikula@linux.intel.com>,
	<mika.westerberg@linux.intel.com>, <linux-i2c@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <kbuild-all@lists.01.org>,
	<clang-built-linux@googlegroups.com>, <morgan.chang@vatics.com>,
	<dean.hsiao@vatics.com>, <paul.chen@vatics.com>
Subject: RE: [PATCH] i2c: designware: fix slave omitted IC_INTR_STOP_DET
Date: Wed, 14 Oct 2020 09:58:54 +0000	[thread overview]
Message-ID: <5DB475451BAA174CB158B5E897FC1525B1294238@MBS07.vivotek.tw> (raw)
In-Reply-To: <20201014085251.GS4077@smile.fi.intel.com>

On 10/14/20 4:53 PM, andriy.shevchenko@linux.intel.com wrote:
> 
> Wondering if you compile this at all...


I'm very sorry that I did not compile it because I only have ARM SoC with my
linux 4.9.170, but I've verified the logic of this patch in my linux.

I'll correct these two syntax errors in next version. The reported
warnings occurs from drivers/i2c/busses/i2c-designware-slave.c:13 seems
not made by this modification. Please correct me if I'm wrong....

> >    include/asm-generic/io.h:1017:55: warning: performing pointer
> arithmetic on a null pointer has undefined behavior
> [-Wnull-pointer-arithmetic]
> >            return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE +
> port;
> >
> ~~~~~~~~~~ ^
> > >> drivers/i2c/busses/i2c-designware-slave.c:181:42: error: expected ';' after
> expression
> >                            dev->status =
> STATUS_WRITE_IN_PROGRESS
> >
> ^
> >
>    ;
> > >> drivers/i2c/busses/i2c-designware-slave.c:195:22: error: use of
> undeclared identifier 'STATUS_IDEL'
> >                    if (dev->status != STATUS_IDEL) {
> >                                       ^
> >    7 warnings and 2 errors generated.
> 
> 
> 


  reply	other threads:[~2020-10-14  9:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14  5:25 [PATCH] i2c: designware: fix slave omitted IC_INTR_STOP_DET Michael Wu
2020-10-14  7:39 ` kernel test robot
2020-10-14  8:52   ` Andy Shevchenko
2020-10-14  9:58     ` Michael.Wu [this message]
2020-10-14 10:16       ` Andy Shevchenko
2020-10-14 10:43 ` Jarkko Nikula
2020-10-14 11:05   ` Michael.Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5DB475451BAA174CB158B5E897FC1525B1294238@MBS07.vivotek.tw \
    --to=michael.wu@vatics.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=dean.hsiao@vatics.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=morgan.chang@vatics.com \
    --cc=paul.chen@vatics.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).