From: "Arnd Bergmann" <arnd@arndb.de>
To: "Benjamin Gray" <bgray@linux.ibm.com>, linux-i2c@vger.kernel.org
Cc: "Sven Peter" <sven@svenpeter.dev>,
"Michael Ellerman" <mpe@ellerman.id.au>
Subject: Re: [PATCH] i2c: Disable I2C_APPLE on PPC when COMPILE_TEST is set
Date: Mon, 27 Feb 2023 09:25:15 +0100 [thread overview]
Message-ID: <65eeff1c-3ad0-4cd2-ac79-eb7d940e7170@app.fastmail.com> (raw)
In-Reply-To: <20230227035414.1461763-1-bgray@linux.ibm.com>
On Mon, Feb 27, 2023, at 04:54, Benjamin Gray wrote:
> The ppc64le_allmodconfig sets I2C_PASEMI=y and leaves COMPILE_TEST to
> default to y and I2C_APPLE to default to m, running into a known
> incompatible configuration that breaks the build [1].
>
> Disable the I2C_APPLE build during PPC compile tests to prevent this.
>
> [1]: https://lore.kernel.org/all/202112061809.XT99aPrf-lkp@intel.com
>
> Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Benjamin Gray <bgray@linux.ibm.com>
This should work, but I find the added dependency is a bit
confusing to readers.
> drivers/i2c/busses/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index d4975444a32d..3db56e446902 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -896,7 +896,7 @@ config I2C_PASEMI
>
> config I2C_APPLE
> tristate "Apple SMBus platform driver"
> - depends on ARCH_APPLE || COMPILE_TEST
> + depends on ARCH_APPLE || (COMPILE_TEST && !PPC)
> default ARCH_APPLE
I would add a line such as
depends on !I2C_PASEMI
which actually still allows building both drivers as loadable
modules but prevents I2C_APPLE=y when I2C_PASEMI=m or
vice versa. For completeness, it might be good to extend
the I2C_PASEMI dependency to include '|| COMPILE_TEST',
which would ensure that any future problems show up on
x86 builds as well, rather than just powerpc.
Arnd
prev parent reply other threads:[~2023-02-27 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 3:54 [PATCH] i2c: Disable I2C_APPLE on PPC when COMPILE_TEST is set Benjamin Gray
2023-02-27 8:25 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65eeff1c-3ad0-4cd2-ac79-eb7d940e7170@app.fastmail.com \
--to=arnd@arndb.de \
--cc=bgray@linux.ibm.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).