From: Florian Fainelli <f.fainelli@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Wolfram Sang" <wsa@kernel.org>,
"ye xingchen" <ye.xingchen@zte.com.cn>
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH 09/89] i2c: bcm2835: Convert to platform remove callback returning void
Date: Mon, 8 May 2023 13:59:03 -0700 [thread overview]
Message-ID: <70eb4357-a68e-24fd-5978-3e9e3a8fdb44@gmail.com> (raw)
In-Reply-To: <20230508205306.1474415-10-u.kleine-koenig@pengutronix.de>
On 5/8/23 13:51, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2023-05-08 20:59 UTC|newest]
Thread overview: 140+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 20:51 [PATCH 00/89] i2c: Convert to platform remove callback returning void Uwe Kleine-König
2023-05-08 20:51 ` [PATCH 01/89] i2c: altera: " Uwe Kleine-König
2023-05-08 20:51 ` [PATCH 02/89] i2c: amd-mp2-plat: " Uwe Kleine-König
2023-05-08 20:51 ` [PATCH 03/89] i2c: aspeed: " Uwe Kleine-König
2023-05-08 20:51 ` [PATCH 04/89] i2c: at91-core: " Uwe Kleine-König
2023-05-09 4:42 ` Claudiu.Beznea
2023-05-08 20:51 ` [PATCH 05/89] i2c: au1550: " Uwe Kleine-König
2023-05-08 20:51 ` [PATCH 06/89] i2c: axxia: " Uwe Kleine-König
2023-05-08 20:51 ` [PATCH 07/89] i2c: bcm-iproc: " Uwe Kleine-König
2023-05-08 20:59 ` Florian Fainelli
2023-05-08 20:51 ` [PATCH 08/89] i2c: bcm-kona: " Uwe Kleine-König
2023-05-08 20:59 ` Florian Fainelli
2023-05-08 20:51 ` [PATCH 09/89] i2c: bcm2835: " Uwe Kleine-König
2023-05-08 20:59 ` Florian Fainelli [this message]
2023-05-08 20:51 ` [PATCH 10/89] i2c: brcmstb: " Uwe Kleine-König
2023-05-08 20:59 ` Florian Fainelli
2023-05-08 20:51 ` [PATCH 11/89] i2c: cadence: " Uwe Kleine-König
2023-05-08 20:51 ` [PATCH 12/89] i2c: cbus-gpio: " Uwe Kleine-König
2023-05-08 20:51 ` [PATCH 13/89] i2c: cht-wc: " Uwe Kleine-König
2023-05-09 8:13 ` Hans de Goede
2023-05-08 20:51 ` [PATCH 14/89] i2c: cpm: " Uwe Kleine-König
2023-05-16 10:59 ` Jochen Friedrich
2023-05-08 20:51 ` [PATCH 15/89] i2c: cros-ec-tunnel: " Uwe Kleine-König
2023-05-09 15:09 ` Krzysztof Kozlowski
2023-05-08 20:51 ` [PATCH 16/89] i2c: davinci: Improve error reporting for problems during .remove() Uwe Kleine-König
2023-05-11 9:02 ` Bartosz Golaszewski
2023-05-08 20:51 ` [PATCH 17/89] i2c: davinci: Convert to platform remove callback returning void Uwe Kleine-König
2023-05-11 9:03 ` Bartosz Golaszewski
2023-05-08 20:51 ` [PATCH 18/89] i2c: designware-platdrv: " Uwe Kleine-König
2023-05-11 8:28 ` Jarkko Nikula
2023-05-08 20:51 ` [PATCH 19/89] i2c: digicolor: " Uwe Kleine-König
2023-05-09 3:15 ` Baruch Siach
2023-05-08 20:51 ` [PATCH 20/89] i2c: dln2: " Uwe Kleine-König
2023-05-08 20:51 ` [PATCH 21/89] i2c: emev2: " Uwe Kleine-König
2023-05-09 7:01 ` Geert Uytterhoeven
2023-05-08 20:51 ` [PATCH 22/89] i2c: exynos5: " Uwe Kleine-König
2023-05-09 15:08 ` Krzysztof Kozlowski
2023-05-08 20:52 ` [PATCH 23/89] i2c: gpio: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 24/89] i2c: gxp: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 25/89] i2c: highlander: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 26/89] i2c: hix5hd2: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 27/89] i2c: ibm_iic: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 28/89] i2c: img-scb: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 29/89] i2c: imx-lpi2c: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 30/89] i2c: imx: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 31/89] i2c: iop3xx: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 32/89] i2c: isch: " Uwe Kleine-König
2023-05-09 11:04 ` Jean Delvare
2023-05-08 20:52 ` [PATCH 33/89] i2c: jz4780: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 34/89] i2c: kempld: " Uwe Kleine-König
2023-05-09 7:52 ` Chris Pringle
2023-05-08 20:52 ` [PATCH 35/89] i2c: lpc2k: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 36/89] i2c: meson: " Uwe Kleine-König
2023-05-10 20:41 ` Martin Blumenstingl
2023-05-08 20:52 ` [PATCH 37/89] i2c: microchip-corei2c: " Uwe Kleine-König
2023-05-08 21:00 ` Conor Dooley
2023-05-08 20:52 ` [PATCH 38/89] i2c: mlxbf: " Uwe Kleine-König
2023-05-08 21:01 ` Asmaa Mnebhi
2023-05-08 20:52 ` [PATCH 39/89] i2c: mlxcpld: " Uwe Kleine-König
2023-05-09 5:55 ` Vadim Pasternak
2023-05-08 20:52 ` [PATCH 40/89] i2c: mpc: " Uwe Kleine-König
2023-05-08 21:11 ` Chris Packham
2023-05-08 20:52 ` [PATCH 41/89] i2c: mt65xx: " Uwe Kleine-König
2023-05-10 16:55 ` Matthias Brugger
2023-05-08 20:52 ` [PATCH 42/89] i2c: mt7621: " Uwe Kleine-König
2023-05-10 16:56 ` Matthias Brugger
2023-05-08 20:52 ` [PATCH 43/89] i2c: mv64xxx: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 44/89] i2c: mxs: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 45/89] i2c: npcm7xx: " Uwe Kleine-König
2023-05-09 6:32 ` Tali Perry
2023-05-08 20:52 ` [PATCH 46/89] i2c: ocores: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 47/89] i2c: octeon-platdrv: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 48/89] i2c: omap: " Uwe Kleine-König
2023-05-09 6:02 ` Vignesh Raghavendra
2023-05-08 20:52 ` [PATCH 49/89] i2c: opal: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 50/89] i2c: pasemi-platform: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 51/89] i2c: pca-platform: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 52/89] i2c: pnx: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 53/89] i2c: powermac: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 54/89] i2c: pxa: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 55/89] i2c: qcom-cci: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 56/89] i2c: qcom-geni: " Uwe Kleine-König
2023-05-09 8:46 ` Konrad Dybcio
2023-05-08 20:52 ` [PATCH 57/89] i2c: qup: " Uwe Kleine-König
2023-05-09 8:47 ` Konrad Dybcio
2023-05-08 20:52 ` [PATCH 58/89] i2c: rcar: " Uwe Kleine-König
2023-05-09 7:01 ` Geert Uytterhoeven
2023-05-08 20:52 ` [PATCH 59/89] i2c: riic: " Uwe Kleine-König
2023-05-09 7:02 ` Geert Uytterhoeven
2023-05-08 20:52 ` [PATCH 60/89] i2c: rk3x: " Uwe Kleine-König
2023-05-13 16:44 ` Heiko Stuebner
2023-05-08 20:52 ` [PATCH 61/89] i2c: rzv2m: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 62/89] i2c: s3c2410: " Uwe Kleine-König
2023-05-09 15:09 ` Krzysztof Kozlowski
2023-05-08 20:52 ` [PATCH 63/89] i2c: scmi: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 64/89] i2c: scx200_acb: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 65/89] i2c: sh7760: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 66/89] i2c: sh_mobile: " Uwe Kleine-König
2023-05-09 7:02 ` Geert Uytterhoeven
2023-05-08 20:52 ` [PATCH 67/89] i2c: simtec: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 68/89] i2c: st: " Uwe Kleine-König
2023-05-09 6:21 ` Patrice CHOTARD
2023-05-08 20:52 ` [PATCH 69/89] i2c: stm32f4: " Uwe Kleine-König
2023-05-09 7:24 ` Alain Volmat
2023-05-08 20:52 ` [PATCH 70/89] i2c: stm32f7: " Uwe Kleine-König
2023-05-09 7:25 ` Alain Volmat
2023-05-08 20:52 ` [PATCH 71/89] i2c: sun6i-p2wi: " Uwe Kleine-König
2023-05-10 19:03 ` Jernej Škrabec
2023-05-08 20:52 ` [PATCH 72/89] i2c: synquacer: " Uwe Kleine-König
2023-05-08 22:00 ` Ard Biesheuvel
2023-05-08 20:52 ` [PATCH 73/89] i2c: tegra-bpmp: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 74/89] i2c: tegra: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 75/89] i2c: uniphier-f: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 76/89] i2c: uniphier: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 77/89] i2c: versatile: " Uwe Kleine-König
2023-05-09 7:07 ` Linus Walleij
2023-05-08 20:52 ` [PATCH 78/89] i2c: viperboard: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 79/89] i2c: wmt: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 80/89] i2c: xgene-slimpro: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 81/89] i2c: xiic: " Uwe Kleine-König
2023-05-08 20:52 ` [PATCH 82/89] i2c: xlp9xx: " Uwe Kleine-König
2023-05-08 20:53 ` [PATCH 83/89] i2c: mux: arb-gpio-challenge: " Uwe Kleine-König
2023-05-09 6:09 ` Peter Rosin
2023-05-08 20:53 ` [PATCH 84/89] i2c: mux: demux-pinctrl: " Uwe Kleine-König
2023-05-09 6:10 ` Peter Rosin
2023-05-08 20:53 ` [PATCH 85/89] i2c: mux: gpio: " Uwe Kleine-König
2023-05-09 6:10 ` Peter Rosin
2023-05-08 20:53 ` [PATCH 86/89] i2c: mux: gpmux: " Uwe Kleine-König
2023-05-09 6:10 ` Peter Rosin
2023-05-08 20:53 ` [PATCH 87/89] i2c: mux: mlxcpld: " Uwe Kleine-König
2023-05-09 5:55 ` Vadim Pasternak
2023-05-09 6:11 ` Peter Rosin
2023-05-08 20:53 ` [PATCH 88/89] i2c: mux: pinctrl: " Uwe Kleine-König
2023-05-09 6:11 ` Peter Rosin
2023-05-08 20:53 ` [PATCH 89/89] i2c: mux: reg: " Uwe Kleine-König
2023-05-09 6:11 ` Peter Rosin
2023-06-01 7:33 ` [PATCH 00/89] i2c: " Uwe Kleine-König
2023-06-01 7:43 ` Biju Das
2023-06-01 13:54 ` Wolfram Sang
2023-06-05 7:54 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70eb4357-a68e-24fd-5978-3e9e3a8fdb44@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@kernel.org \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).