From: Dmitry Osipenko <digetx@gmail.com>
To: Yicong Yang <yangyicong@hisilicon.com>,
wsa@kernel.org, andriy.shevchenko@linux.intel.com,
linux-i2c@vger.kernel.org, Sergey.Semin@baikalelectronics.ru,
linux-kernel@vger.kernel.org
Cc: treding@nvidia.com, jarkko.nikula@linux.intel.com,
rmk+kernel@armlinux.org.uk, song.bao.hua@hisilicon.com,
john.garry@huawei.com, mika.westerberg@linux.intel.com,
prime.zeng@huawei.com, linuxarm@huawei.com
Subject: Re: [PATCH v5 3/5] i2c: add support for HiSilicon I2C controller
Date: Tue, 30 Mar 2021 19:32:04 +0300 [thread overview]
Message-ID: <7efac5e2-aa1c-0575-0e9e-ca4eb659ed3f@gmail.com> (raw)
In-Reply-To: <b761fa05-1bf9-ce4c-e2b5-f39b418f0da9@gmail.com>
30.03.2021 19:24, Dmitry Osipenko пишет:
>> +struct hisi_i2c_controller {
>> + struct i2c_adapter adapter;
>> + void __iomem *iobase;
>> + struct device *dev;
>> + int irq;
>> +
>> + /* Intermediates for recording the transfer process */
>> + struct completion *completion;
>> + struct i2c_msg *msgs;
>> + int msg_num;
>> + int msg_tx_idx;
>> + int buf_tx_idx;
>> + int msg_rx_idx;
>> + int buf_rx_idx;
>> + u16 tar_addr;
>> + u32 xfer_err;
>> +
>> + /* I2C bus configuration */
>> + struct i2c_timings t;
>> + u64 clk_rate_khz;
> Looks like the u64 is overkill here and it doesn't allow you to use
> COMPILE_TEST because 32bit arches can divide u64 only using the
> do_div(), please fix this.
I see now that the value isn't divided anywhere directly in the code, my
bad. Looks good then.
next prev parent reply other threads:[~2021-03-30 16:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 14:19 [PATCH v5 0/5] Add support for HiSilicon I2C controller Yicong Yang
2021-03-30 14:19 ` [PATCH v5 1/5] i2c: core: add managed function for adding i2c adapters Yicong Yang
2021-03-30 16:28 ` Dmitry Osipenko
2021-03-30 14:19 ` [PATCH v5 2/5] i2c: core: add api to provide frequency mode strings Yicong Yang
2021-03-31 8:35 ` Jarkko Nikula
2021-03-31 13:03 ` Yicong Yang
2021-03-30 14:19 ` [PATCH v5 3/5] i2c: add support for HiSilicon I2C controller Yicong Yang
2021-03-30 16:24 ` Dmitry Osipenko
2021-03-30 16:32 ` Dmitry Osipenko [this message]
2021-03-30 16:33 ` Dmitry Osipenko
2021-03-30 14:19 ` [PATCH v5 4/5] MAINTAINERS: Add maintainer for HiSilicon I2C driver Yicong Yang
2021-03-30 14:19 ` [PATCH 5/5] i2c: designware: Switch over to i2c_freq_mode_string() Yicong Yang
2021-03-30 21:36 ` Song Bao Hua (Barry Song)
[not found] ` <CAHp75VdY58Tm0FDcoVDWuw0LBKUFWC_hBCb5t=4WX_MPzsLvZw@mail.gmail.com>
2021-03-30 22:01 ` Song Bao Hua (Barry Song)
2021-03-30 22:06 ` Song Bao Hua (Barry Song)
[not found] ` <CAHp75VeTj-wk3WP2-Unoti0+Cajx33b8NOUbBiSBQLmJHn=YAg@mail.gmail.com>
2021-03-31 8:53 ` Song Bao Hua (Barry Song)
2021-03-31 10:19 ` Andy Shevchenko
2021-03-31 10:37 ` Andy Shevchenko
2021-03-31 13:02 ` Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7efac5e2-aa1c-0575-0e9e-ca4eb659ed3f@gmail.com \
--to=digetx@gmail.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=john.garry@huawei.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mika.westerberg@linux.intel.com \
--cc=prime.zeng@huawei.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=song.bao.hua@hisilicon.com \
--cc=treding@nvidia.com \
--cc=wsa@kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).