From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
To: Wolfram Sang <wsa@kernel.org>
Cc: agross@kernel.org, linux-kernel@vger.kernel.org,
konrad.dybcio@somainline.org, marijn.suijten@somainline.org,
martin.botka@somainline.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] dt-bindings: i2c: qcom,i2c-qup: Document noise rejection properties
Date: Thu, 28 Jan 2021 22:23:15 +0100 [thread overview]
Message-ID: <8091e7fb-5530-10c2-c66c-ac76940ef1ad@somainline.org> (raw)
In-Reply-To: <20210128091302.GG963@ninjato>
Il 28/01/21 10:13, Wolfram Sang ha scritto:
>
>> + qcom,noise-reject-sda:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description: Noise rejection level for the SDA line.
>> + minimum: 0
>> + maximum: 3
>> + default: 0
>
> What does this u32 describe? I wonder if we can introduce a generic
> property instead of a vendor-specific one.
>
Describes a "noise rejection level"... zero is disabled, 1-2-3 are
min-med-high. That's what the hardware accepts.
Also, there's no "real" documentation on this, so it wasn't possible
to map it to any real measurement unit as well...
prev parent reply other threads:[~2021-01-28 21:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 18:04 [PATCH v3 0/3] QCOM QUP I2C - Add noise rejection, convert to YAML AngeloGioacchino Del Regno
2021-01-14 18:04 ` [PATCH v3 1/3] dt-bindings: i2c: qcom,i2c-qup: Convert txt to YAML schema AngeloGioacchino Del Regno
2021-01-25 22:16 ` Rob Herring
2021-11-29 22:17 ` Wolfram Sang
2021-01-14 18:04 ` [PATCH v3 2/3] i2c: qup: Introduce SCL/SDA noise rejection AngeloGioacchino Del Regno
2021-01-14 18:04 ` [PATCH v3 3/3] dt-bindings: i2c: qcom,i2c-qup: Document noise rejection properties AngeloGioacchino Del Regno
2021-01-25 22:17 ` Rob Herring
2021-01-28 9:13 ` Wolfram Sang
2021-01-28 21:23 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8091e7fb-5530-10c2-c66c-ac76940ef1ad@somainline.org \
--to=angelogioacchino.delregno@somainline.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).