From: "Rafał Miłecki" <rafal@milecki.pl>
To: "Wolfram Sang" <wsa@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Rafał Miłecki" <zajec5@gmail.com>,
devicetree@vger.kernel.org, "Ray Jui" <rjui@broadcom.com>,
"Rob Herring" <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
"Florian Fainelli" <f.fainelli@gmail.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Scott Branden" <sbranden@broadcom.com>
Subject: Re: [PATCH] dt-bindings: i2c: brcm,iproc-i2c: convert to the json-schema
Date: Fri, 28 May 2021 11:37:16 +0200 [thread overview]
Message-ID: <80afe993-68f2-01f1-a13e-319a6ec32169@milecki.pl> (raw)
In-Reply-To: <YLC2en7Mj7kurlCd@kunai>
On 28.05.2021 11:23, Wolfram Sang wrote:
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.example.dt.yaml:0:0: /example-0/i2c@18008000/wm8750@1a: failed to match any schema with compatible: ['wlf,wm8750']
>
> A generic question:
>
> So sound/wm8750.txt was not converted yet. However, if this conversion
> is fine otherwise, I'd vote to apply it nonetheless because it is one
> conversion less to do then. Alternatively, we could change the example
> to include a simple EEPROM which has an already converted binding doc.
>
> What is the procedure here?
>
> All the best and thanks for your work!
Let me try to answer this based on the discussion in the:
[PATCH V3 robh dt/next] dt-bindings: mfd: add Broadcom CRU
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20210519184041.563-1-zajec5@gmail.com/
Rob has stated he doesn't want maintainers to apply bindings that
introduce documentation warnings/errors:
https://patchwork.ozlabs.org/comment/2687693/
Lee Jones as MFD maintainer says it's wrong:
https://patchwork.ozlabs.org/comment/2687847/
I've already got wm8750 YAML binding queued for the 5.14, see linux-next:
ASoC: wm8750: convert to the json-schema
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=11480dbfe1d59eaa6382864acc476e7621b1da4c
Personally I think it's a bit too paranoid to reject such a patch if we
have a proof that its dependency is already part of the linux-next. If
you agree with Rob however I'll just resubmit this very same patch once
Rob updates his tree to the 5.14-rc1 (once it's released). I still think
it just makes the whole process take unnecessarily long.
next prev parent reply other threads:[~2021-05-28 9:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 16:07 [PATCH] dt-bindings: i2c: brcm,iproc-i2c: convert to the json-schema Rafał Miłecki
2021-05-12 18:35 ` Rob Herring
2021-05-28 9:23 ` Wolfram Sang
2021-05-28 9:37 ` Rafał Miłecki [this message]
2021-05-28 9:57 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80afe993-68f2-01f1-a13e-319a6ec32169@milecki.pl \
--to=rafal@milecki.pl \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=wsa@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).