From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Wei Yongjun <weiyongjun1@huawei.com>, Wolfram Sang <wsa@kernel.org>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"Hulk Robot" <hulkci@huawei.com>
Subject: Re: [PATCH -next] i2c: mpc: drop release for resource allocated with devm_*
Date: Mon, 12 Apr 2021 21:09:02 +0000 [thread overview]
Message-ID: <8a14bef8-2c38-cd1d-ad33-6c37030cdd04@alliedtelesis.co.nz> (raw)
In-Reply-To: <20210412160026.194423-1-weiyongjun1@huawei.com>
On 13/04/21 4:00 am, Wei Yongjun wrote:
> It's not necessary to release resource which allocated with devm_*
> and those release may leads to a double free. And also remove useless
> irq_dispose_mapping() call since mapping not created.
>
> Fixes: 09aab7add7bf ("i2c: mpc: use device managed APIs")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thanks for the fix.
Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> drivers/i2c/busses/i2c-mpc.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
> index 46cdb36e2f9b..6e5614acebac 100644
> --- a/drivers/i2c/busses/i2c-mpc.c
> +++ b/drivers/i2c/busses/i2c-mpc.c
> @@ -759,12 +759,6 @@ static int fsl_i2c_remove(struct platform_device *op)
> if (i2c->clk_per)
> clk_disable_unprepare(i2c->clk_per);
>
> - if (i2c->irq)
> - free_irq(i2c->irq, i2c);
> -
> - irq_dispose_mapping(i2c->irq);
> - iounmap(i2c->base);
> - kfree(i2c);
> return 0;
> };
>
>
next prev parent reply other threads:[~2021-04-12 21:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 16:00 [PATCH -next] i2c: mpc: drop release for resource allocated with devm_* Wei Yongjun
2021-04-12 21:09 ` Chris Packham [this message]
2021-04-13 12:20 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a14bef8-2c38-cd1d-ad33-6c37030cdd04@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).