* Re: [PATCH v2 5/5] i2c: xlp9xx: fix main IRQ check
@ 2021-08-18 3:17 George Cherian
0 siblings, 0 replies; 4+ messages in thread
From: George Cherian @ 2021-08-18 3:17 UTC (permalink / raw)
To: Wolfram Sang, Sergey Shtylyov; +Cc: linux-i2c, George Cherian
> -----Original Message-----
> From: Wolfram Sang <wsa@kernel.org>
> Sent: Wednesday, August 18, 2021 1:43 AM
> To: Sergey Shtylyov <s.shtylyov@omp.ru>
> Cc: linux-i2c@vger.kernel.org; George Cherian <gcherian@marvell.com>
> Subject: [EXT] Re: [PATCH v2 5/5] i2c: xlp9xx: fix main IRQ check
>
> On Sun, Jul 04, 2021 at 05:47:54PM +0300, Sergey Shtylyov wrote:
> > Iff platform_get_irq() returns 0 for the main IRQ, the driver's
> > probe() method will return 0 early (as if the method's call was successful).
> > Let's consider IRQ0 valid for simplicity -- devm_request_irq() can
> > always override that decision...
> >
> > Fixes: 2bbd681ba2b ("i2c: xlp9xx: Driver for Netlogic XLP9XX/5XX I2C
> > controller")
> > Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> >
>
> George, do you like this patch?
>
Looks fine.
Reviewed-by: George Cherian <george.cherian@marvell.com>
> > ---
> > drivers/i2c/busses/i2c-xlp9xx.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Index: linux/drivers/i2c/busses/i2c-xlp9xx.c
> >
> ==========================================================
> =========
> > --- linux.orig/drivers/i2c/busses/i2c-xlp9xx.c
> > +++ linux/drivers/i2c/busses/i2c-xlp9xx.c
> > @@ -517,7 +517,7 @@ static int xlp9xx_i2c_probe(struct platf
> > return PTR_ERR(priv->base);
> >
> > priv->irq = platform_get_irq(pdev, 0);
> > - if (priv->irq <= 0)
> > + if (priv->irq < 0)
> > return priv->irq;
> > /* SMBAlert irq */
> > priv->alert_data.irq = platform_get_irq(pdev, 1);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 5/5] i2c: xlp9xx: fix main IRQ check
2021-07-04 14:47 ` [PATCH v2 5/5] i2c: xlp9xx: fix main IRQ check Sergey Shtylyov
2021-08-17 20:13 ` Wolfram Sang
@ 2021-08-25 21:05 ` Wolfram Sang
1 sibling, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2021-08-25 21:05 UTC (permalink / raw)
To: Sergey Shtylyov; +Cc: linux-i2c, George Cherian
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
On Sun, Jul 04, 2021 at 05:47:54PM +0300, Sergey Shtylyov wrote:
> Iff platform_get_irq() returns 0 for the main IRQ, the driver's probe()
> method will return 0 early (as if the method's call was successful).
> Let's consider IRQ0 valid for simplicity -- devm_request_irq() can always
> override that decision...
>
> Fixes: 2bbd681ba2b ("i2c: xlp9xx: Driver for Netlogic XLP9XX/5XX I2C controller")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 5/5] i2c: xlp9xx: fix main IRQ check
2021-07-04 14:47 ` [PATCH v2 5/5] i2c: xlp9xx: fix main IRQ check Sergey Shtylyov
@ 2021-08-17 20:13 ` Wolfram Sang
2021-08-25 21:05 ` Wolfram Sang
1 sibling, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2021-08-17 20:13 UTC (permalink / raw)
To: Sergey Shtylyov; +Cc: linux-i2c, George Cherian
[-- Attachment #1: Type: text/plain, Size: 1123 bytes --]
On Sun, Jul 04, 2021 at 05:47:54PM +0300, Sergey Shtylyov wrote:
> Iff platform_get_irq() returns 0 for the main IRQ, the driver's probe()
> method will return 0 early (as if the method's call was successful).
> Let's consider IRQ0 valid for simplicity -- devm_request_irq() can always
> override that decision...
>
> Fixes: 2bbd681ba2b ("i2c: xlp9xx: Driver for Netlogic XLP9XX/5XX I2C controller")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>
George, do you like this patch?
> ---
> drivers/i2c/busses/i2c-xlp9xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/drivers/i2c/busses/i2c-xlp9xx.c
> ===================================================================
> --- linux.orig/drivers/i2c/busses/i2c-xlp9xx.c
> +++ linux/drivers/i2c/busses/i2c-xlp9xx.c
> @@ -517,7 +517,7 @@ static int xlp9xx_i2c_probe(struct platf
> return PTR_ERR(priv->base);
>
> priv->irq = platform_get_irq(pdev, 0);
> - if (priv->irq <= 0)
> + if (priv->irq < 0)
> return priv->irq;
> /* SMBAlert irq */
> priv->alert_data.irq = platform_get_irq(pdev, 1);
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 5/5] i2c: xlp9xx: fix main IRQ check
2021-07-04 14:32 [PATCH v2 0/5] Correctly handle plaform_get_irq()'s result in the i2C drivers Sergey Shtylyov
@ 2021-07-04 14:47 ` Sergey Shtylyov
2021-08-17 20:13 ` Wolfram Sang
2021-08-25 21:05 ` Wolfram Sang
0 siblings, 2 replies; 4+ messages in thread
From: Sergey Shtylyov @ 2021-07-04 14:47 UTC (permalink / raw)
To: linux-i2c; +Cc: George Cherian
Iff platform_get_irq() returns 0 for the main IRQ, the driver's probe()
method will return 0 early (as if the method's call was successful).
Let's consider IRQ0 valid for simplicity -- devm_request_irq() can always
override that decision...
Fixes: 2bbd681ba2b ("i2c: xlp9xx: Driver for Netlogic XLP9XX/5XX I2C controller")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
---
drivers/i2c/busses/i2c-xlp9xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/i2c/busses/i2c-xlp9xx.c
===================================================================
--- linux.orig/drivers/i2c/busses/i2c-xlp9xx.c
+++ linux/drivers/i2c/busses/i2c-xlp9xx.c
@@ -517,7 +517,7 @@ static int xlp9xx_i2c_probe(struct platf
return PTR_ERR(priv->base);
priv->irq = platform_get_irq(pdev, 0);
- if (priv->irq <= 0)
+ if (priv->irq < 0)
return priv->irq;
/* SMBAlert irq */
priv->alert_data.irq = platform_get_irq(pdev, 1);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-25 21:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-18 3:17 [PATCH v2 5/5] i2c: xlp9xx: fix main IRQ check George Cherian
-- strict thread matches above, loose matches on Subject: below --
2021-07-04 14:32 [PATCH v2 0/5] Correctly handle plaform_get_irq()'s result in the i2C drivers Sergey Shtylyov
2021-07-04 14:47 ` [PATCH v2 5/5] i2c: xlp9xx: fix main IRQ check Sergey Shtylyov
2021-08-17 20:13 ` Wolfram Sang
2021-08-25 21:05 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).