linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Baolin Wang <baolin.wang7@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Orson Zhai <orsonzhai@gmail.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>,
	Wolfram Sang <wsa@kernel.org>,
	linux-i2c@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] i2c: sprd:: depend on COMMON_CLK to fix compile tests
Date: Wed, 20 Jan 2021 14:19:33 +0800	[thread overview]
Message-ID: <CADBw62pML49WTTmv7GSzMhJAsAJnujnReH70Kb1nCj2bt1voDA@mail.gmail.com> (raw)
In-Reply-To: <20210117114313.141428-1-krzk@kernel.org>

Hi,

On Sun, Jan 17, 2021 at 7:43 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> The I2C_SPRD uses Common Clock Framework thus it cannot be built on
> platforms without it (e.g. compile test on MIPS with LANTIQ):
>
>     /usr/bin/mips-linux-gnu-ld: drivers/i2c/busses/i2c-sprd.o: in function `sprd_i2c_probe':
>     i2c-sprd.c:(.text.sprd_i2c_probe+0x254): undefined reference to `clk_set_parent'
>
> Fixes: 4a2d5f663dab ("i2c: Enable compile testing for more drivers")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

LGTM. Thanks.
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>

> ---
>  drivers/i2c/busses/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index d4d60ad0eda0..ab1f39ac39f4 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -1013,6 +1013,7 @@ config I2C_SIRF
>  config I2C_SPRD
>         tristate "Spreadtrum I2C interface"
>         depends on I2C=y && (ARCH_SPRD || COMPILE_TEST)
> +       depends on COMMON_CLK
>         help
>           If you say yes to this option, support will be included for the
>           Spreadtrum I2C interface.
> --
> 2.25.1
>


-- 
Baolin Wang

  reply	other threads:[~2021-01-20  6:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-17 11:43 [PATCH] i2c: sprd:: depend on COMMON_CLK to fix compile tests Krzysztof Kozlowski
2021-01-20  6:19 ` Baolin Wang [this message]
2021-01-22  9:05 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADBw62pML49WTTmv7GSzMhJAsAJnujnReH70Kb1nCj2bt1voDA@mail.gmail.com \
    --to=baolin.wang7@gmail.com \
    --cc=krzk@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=orsonzhai@gmail.com \
    --cc=wsa@kernel.org \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).