From: Baolin Wang <baolin.wang7@gmail.com>
To: Bixuan Cui <cuibixuan@huawei.com>
Cc: Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Wolfram Sang <wsa@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Dejin Zheng <zhengdejin5@gmail.com>,
Linhua Xu <linhua.xu@unisoc.com>,
linux-i2c@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] i2c: sprd: Add missing MODULE_DEVICE_TABLE
Date: Mon, 12 Apr 2021 22:04:16 +0800 [thread overview]
Message-ID: <CADBw62pnn9R=4DhPuZm9z3O20Mbirr6zJn0d4Di9Jq0F9gxYTg@mail.gmail.com> (raw)
In-Reply-To: <20210410035044.11418-1-cuibixuan@huawei.com>
On Sat, Apr 10, 2021 at 11:51 AM Bixuan Cui <cuibixuan@huawei.com> wrote:
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
LGTM.
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>
> ---
> drivers/i2c/busses/i2c-sprd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-sprd.c b/drivers/i2c/busses/i2c-sprd.c
> index 2917fecf6c80..9f77d1ddbaf8 100644
> --- a/drivers/i2c/busses/i2c-sprd.c
> +++ b/drivers/i2c/busses/i2c-sprd.c
> @@ -640,6 +640,7 @@ static const struct of_device_id sprd_i2c_of_match[] = {
> { .compatible = "sprd,sc9860-i2c", },
> {},
> };
> +MODULE_DEVICE_TABLE(of, sprd_i2c_of_match);
>
> static struct platform_driver sprd_i2c_driver = {
> .probe = sprd_i2c_probe,
>
--
Baolin Wang
next prev parent reply other threads:[~2021-04-12 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 3:50 [PATCH -next] i2c: sprd: Add missing MODULE_DEVICE_TABLE Bixuan Cui
2021-04-12 14:04 ` Baolin Wang [this message]
2021-04-13 12:35 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADBw62pnn9R=4DhPuZm9z3O20Mbirr6zJn0d4Di9Jq0F9gxYTg@mail.gmail.com' \
--to=baolin.wang7@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cuibixuan@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linhua.xu@unisoc.com \
--cc=linux-i2c@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=wsa@kernel.org \
--cc=zhang.lyra@gmail.com \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).