From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12410C433B4 for ; Fri, 7 May 2021 19:57:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E837561436 for ; Fri, 7 May 2021 19:57:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230059AbhEGT6d (ORCPT ); Fri, 7 May 2021 15:58:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbhEGT6d (ORCPT ); Fri, 7 May 2021 15:58:33 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4170BC061574 for ; Fri, 7 May 2021 12:57:32 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id b3so5807486plg.11 for ; Fri, 07 May 2021 12:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uIAfCugvv6DirQSOC8Meh100tr5jk83OTp42czR55xU=; b=PYWbUgy/7guKQxkZCsOb5rWv0hyfvGf5JhVAeuu0AQvD0doZk6RvnW+Gg5uf1FDYsx AH/QnsVCrKgj2xiz+b4qzbuA74E67z7lRcgVciDIYE6VD7rwoYXc+d1DCxtUnNtzto86 MkAQJz/4YdUX3xahIKFkOSY8wSsXPwhgSwMEjgt3N49+2vmYOdvrS5wThkuEqKlI+iY8 fKZq9STvVxdflWMsFuSygBxxEMyOtF8EwiylWV4torqaTRoQwERAoNdYmTCg6k8nGMO6 0zKbou5rO9PToGyxiahdKXDdqfubCm9bcsPpt6e6cjM7scpXoRUyTy2fZ/9UzG+Lga99 i6Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uIAfCugvv6DirQSOC8Meh100tr5jk83OTp42czR55xU=; b=qp+0MnRO7p/NfiQou3IhTgigTGPwxErd5b/Mpp+TEX6Ug9h1vofWQiNoPeqnC+u9Lw 2xZWpZcosuxjqtE1vYeXMdBmz+KoGKAfQVMUbXUqYB9eSpfvxvjWdBgMfSRscu53FzXm 9/xQXdADnqOlyUCenJjRNDAT+NqFKBMzlIWf5X++5CdbAeoJEaVp2RhF9rKqZe2l0aVk LbXaoJI6YBp5wAmhFqVpoJAHGD7+iIYMeZIKebNkEaBHlgFkAloDNfXFYGxwGxCUyvim 84JPH7u13V1b4LZr7+Ymn3bb4M40p91UQ41SGyURVmeT8GN/tWCAKCNIlJg/qP6vUFOm 76nw== X-Gm-Message-State: AOAM532DYU3O0riwq7sMmapXmK0hxnBzprRycK6D2GwkCfPd6dgUidk3 PfikvI0FhPs+170EBDI4lmG6ximYuKLL3ooz5XM+1g== X-Google-Smtp-Source: ABdhPJz9wKX5WGS2h0k3XqhaJYqzyGFcZaZ4Q33Hno1JgZWxJwPRA4R0mdpWPLYUI4JNiIFvQg7KyW+HguEjm3YtvWU= X-Received: by 2002:a17:90a:7306:: with SMTP id m6mr25318877pjk.217.1620417451576; Fri, 07 May 2021 12:57:31 -0700 (PDT) MIME-Version: 1.0 References: <20210506205419.26294-1-zev@bewilderbeest.net> In-Reply-To: <20210506205419.26294-1-zev@bewilderbeest.net> From: Brendan Higgins Date: Fri, 7 May 2021 12:57:20 -0700 Message-ID: Subject: Re: [PATCH v2] i2c: aspeed: disable additional device addresses on ast2[56]xx To: Zev Weiss Cc: Joel Stanley , Benjamin Herrenschmidt , Andrew Jeffery , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Thu, May 6, 2021 at 1:54 PM Zev Weiss wrote: > > The ast25xx and ast26xx have, respectively, two and three configurable > slave device addresses to the ast24xx's one. We only support using > one at a time, but the others may come up in an indeterminate state > depending on hardware/bootloader behavior, so we need to make sure we > disable them so as to avoid ending up with phantom devices on the bus. > > Signed-off-by: Zev Weiss Looks great! No concerns from me. Nevertheless, I am not in a position to test this at this time. Joel, or Andrew could one of you (or someone else on the mailing list) test this? Reviewed-by: Brendan Higgins