From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Akash Asthana <akashast@codeaurora.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
agross@kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>,
Wolfram Sang <wsa@the-dreams.de>, Mark Brown <broonie@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
linux-i2c <linux-i2c@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
mgautam@codeaurora.org, linux-arm-msm@vger.kernel.org,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Evan Green <evgreen@chromium.org>,
Georgi Djakov <georgi.djakov@linaro.org>
Subject: Re: [PATCH V5 2/7] soc: qcom-geni-se: Add interconnect support to fix earlycon crash
Date: Sat, 9 May 2020 15:11:31 +0300 [thread overview]
Message-ID: <CAHp75Vdjz7RBbyPwZwvNq5njwb_Jc76U=3pDpswmoFCFaGtNAQ@mail.gmail.com> (raw)
In-Reply-To: <1588919619-21355-3-git-send-email-akashast@codeaurora.org>
On Fri, May 8, 2020 at 9:34 AM Akash Asthana <akashast@codeaurora.org> wrote:
>
> QUP core clock is shared among all the SE drivers present on particular
> QUP wrapper, the system will reset(unclocked access) if earlycon used after
> QUP core clock is put to 0 from other SE drivers before real console comes
> up.
>
> As earlycon can't vote for it's QUP core need, to fix this add ICC
> support to common/QUP wrapper driver and put vote for QUP core from
> probe on behalf of earlycon and remove vote during earlycon exit call.
...
> + for_each_child_of_node(parent, child) {
> + if (of_device_is_compatible(child, "qcom,geni-se-qup")) {
if (!...)
continue;
will save you a readability of the loop body.
Or...
> + wrapper = platform_get_drvdata(of_find_device_by_node(
> + child));
...leave this on one line
> + icc_put(wrapper->to_core.path);
> + wrapper->to_core.path = NULL;
> + }
And here is the question, what do you want to do if you find more
devices with the same compatible string?
> + }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-05-09 12:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 6:33 [PATCH V5 0/7] Add interconnect support to QSPI and QUP drivers Akash Asthana
2020-05-08 6:33 ` [PATCH V5 1/7] soc: qcom: geni: Support for ICC voting Akash Asthana
2020-05-08 17:13 ` Matthias Kaehlcke
2020-05-12 14:02 ` Akash Asthana
2020-05-08 19:03 ` Matthias Kaehlcke
2020-05-12 14:26 ` Akash Asthana
2020-05-08 6:33 ` [PATCH V5 2/7] soc: qcom-geni-se: Add interconnect support to fix earlycon crash Akash Asthana
2020-05-08 17:59 ` Matthias Kaehlcke
2020-05-08 19:14 ` Matthias Kaehlcke
2020-05-14 7:03 ` Akash Asthana
2020-05-14 6:45 ` Akash Asthana
2020-05-09 12:11 ` Andy Shevchenko [this message]
2020-05-14 7:34 ` Akash Asthana
2020-05-08 6:33 ` [PATCH V5 3/7] i2c: i2c-qcom-geni: Add interconnect support Akash Asthana
2020-05-08 18:16 ` Matthias Kaehlcke
2020-05-15 10:03 ` Wolfram Sang
2020-05-08 6:33 ` [PATCH V5 4/7] spi: spi-geni-qcom: " Akash Asthana
2020-05-08 10:16 ` Mark Brown
2020-05-08 18:25 ` Matthias Kaehlcke
2020-05-14 7:37 ` Akash Asthana
2020-05-08 6:33 ` [PATCH V5 5/7] tty: serial: qcom_geni_serial: " Akash Asthana
2020-05-08 18:38 ` Matthias Kaehlcke
2020-05-08 6:33 ` [PATCH V5 6/7] spi: spi-qcom-qspi: " Akash Asthana
2020-05-08 10:16 ` Mark Brown
2020-05-08 18:53 ` Matthias Kaehlcke
2020-05-18 13:10 ` Akash Asthana
2020-05-08 6:33 ` [PATCH V5 7/7] arm64: dts: sc7180: Add interconnect for QUP and QSPI Akash Asthana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vdjz7RBbyPwZwvNq5njwb_Jc76U=3pDpswmoFCFaGtNAQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).