linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Christian Eggers <ceggers@arri.de>
Cc: "Oleksij Rempel" <linux@rempel-privat.de>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"David Laight" <David.Laight@aculab.com>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v4 1/3] i2c: imx: Fix reset of I2SR_IAL flag
Date: Wed, 7 Oct 2020 10:27:02 +0200	[thread overview]
Message-ID: <CAJKOXPd+kqwnFiqEz6wDRcA3Xeqo8zngQWEzc4svrND=Zi=3FQ@mail.gmail.com> (raw)
In-Reply-To: <5729679.lNAy7qQNGU@n95hx1g2>

On Wed, 7 Oct 2020 at 10:17, Christian Eggers <ceggers@arri.de> wrote:
>
> On Wednesday, 7 October 2020, 09:50:23 CEST, Krzysztof Kozlowski wrote:
> > I replied to your v2 with testing, so what happened with all my tested tags?
>
> I am quite new to the kernel development process. Seems that I should
> integrate all "Tested-by" tags into following version of my patches.
>
> In which cases shall the tested tags be kept and in which cases they become
> invalid?

https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L584

Your v3 touched only one patch, so all tags for all other patches
should be added and preserved. If the patch changed significantly that
review or testing is not appropriate, you could remove someone's tag
but then you should ask for testing again. And you did not send it for
testing.

Your v4 only extended a comment which does not affect testing. All
tags, review, ack and tested by should be added/preserved.

Otherwise you ask for testing (or reviewing) and then do not credit
this person. Neither maintainers know that patches were tested.

Best regards,
Krzysztof

  reply	other threads:[~2020-10-07  8:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06 16:08 [PATCH v4 0/3] i2c: imx: Fix handling of arbitration loss Christian Eggers
2020-10-06 16:08 ` [PATCH v4 1/3] i2c: imx: Fix reset of I2SR_IAL flag Christian Eggers
2020-10-06 18:46   ` Uwe Kleine-König
2020-10-07  7:50   ` Krzysztof Kozlowski
2020-10-07  8:17     ` Christian Eggers
2020-10-07  8:27       ` Krzysztof Kozlowski [this message]
2020-10-06 16:08 ` [PATCH v4 2/3] i2c: imx: Check for I2SR_IAL after every byte Christian Eggers
2020-10-07  7:51   ` Krzysztof Kozlowski
2020-10-06 16:08 ` [PATCH v4 3/3] i2c: imx: Don't generate STOP condition if arbitration has been lost Christian Eggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJKOXPd+kqwnFiqEz6wDRcA3Xeqo8zngQWEzc4svrND=Zi=3FQ@mail.gmail.com' \
    --to=krzk@kernel.org \
    --cc=David.Laight@aculab.com \
    --cc=ceggers@arri.de \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rempel-privat.de \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).